Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error response during map load #195

Open
rchampine opened this issue Jun 13, 2024 · 3 comments
Open

Add error response during map load #195

rchampine opened this issue Jun 13, 2024 · 3 comments

Comments

@rchampine
Copy link

These two Syracuse volumes refuse to load. It is possible to click "Load Volume" but the sheets aren't populating.
https://oldinsurancemaps.net/loc/sanborn06296_015/
https://oldinsurancemaps.net/loc/sanborn06296_016/

@mradamcox
Copy link
Collaborator

From the load log:

  File "..../ohmg/loc_insurancemaps/models.py", line 395, in make_sheets
    sheet_no=parsed.sheet_number,
AttributeError: 'LOCParser' object has no attribute 'sheet_number'

Need to look into the parser, either something got changed inadvertently or there is something abnormal about these particular records. Hopefully can get to it this evening or sometime tomorrow.

@rchampine
Copy link
Author

Interesting — no rush on our end. There are plenty of other volumes we can work on.

@mradamcox
Copy link
Collaborator

Looks like there is a missing page on these two, which is causing the error. Should have better handling on the ingestion side for this, so I'll leave this ticket open for now.

@mradamcox mradamcox changed the title Unable to load two volumes Add error response during map load Aug 22, 2024
@mradamcox mradamcox added type: enhancement New feature or request component: frontend component: backend and removed type: bug Something isn't working labels Aug 22, 2024
@mradamcox mradamcox added this to the Next Tasks milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants