Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active navigation link highlighting not working on the website #42

Open
Krishna100604 opened this issue Dec 24, 2024 · 16 comments · May be fixed by #56
Open

Active navigation link highlighting not working on the website #42

Krishna100604 opened this issue Dec 24, 2024 · 16 comments · May be fixed by #56
Assignees

Comments

@Krishna100604
Copy link

Image

**This is how it is supposed to look

@Krishna100604 Krishna100604 changed the title Active navigation link highlighting not working on the website? Active navigation link highlighting not working on the website Dec 24, 2024
@Krishna100604
Copy link
Author

@shivankacker please see this and let me know

@sharath-1517
Copy link

Is this issue open to be solved? I'd like to work on this issue. Thanks.

@Krishna100604
Copy link
Author

hey @shivankacker could you please this issue?

@shivankacker
Copy link
Member

@Krishna100604 This might not work with our current design. Maybe lets just add a small dot at the bottom of the link to indicate it is active?

@Krishna100604
Copy link
Author

Krishna100604 commented Jan 9, 2025

@Krishna100604 This might not work with our current design. Maybe lets just add a small dot at the bottom of the link to indicate it is active?

Image

is this fine? @shivankacker

@shivankacker
Copy link
Member

@Krishna100604 let's not change the color maybe? Keep it white, but fully opaque. And decrease the space between the dot and text a little?

@Krishna100604
Copy link
Author

@Krishna100604 let's not change the color maybe? Keep it white, but fully opaque. And decrease the space between the dot and text a little?

Image

  • How about this ?

@Krishna100604
Copy link
Author

Krishna100604 commented Jan 9, 2025

Image
** or This one ? @shivankacker

@shivankacker
Copy link
Member

@Krishna100604 hi, the second one looks good to me

@Krishna100604
Copy link
Author

@Krishna100604 hi, the second one looks good to me

so i will make a pull request then?

@shivankacker
Copy link
Member

@Krishna100604 yes please go ahead

@michael-020
Copy link

michael-020 commented Feb 9, 2025

@Krishna100604 @shivankacker hey, I have made the first thing asked in the issue, there are some adjustments to make in it, like you sort of get an underline and the color of the text changes when you hover on a nav item.
I would like to go forward and completely polish this issue, if it is needed. So please let me know.

Image

@ARH-MNAJS
Copy link
Contributor

@shivankacker I have reviewed all the comments in this issue and past PRs and now have a clear understanding of how to implement the intended design aesthetic for the navigation links. Could you kindly assign me this issue?

@shivankacker
Copy link
Member

@ARH-MNAJS please make a PR and link to this issue

@ARH-MNAJS ARH-MNAJS linked a pull request Feb 15, 2025 that will close this issue
2 tasks
@ARH-MNAJS
Copy link
Contributor

@shivankacker I have raised a PR #56 kindly review it and provide feedback if any

@ARH-MNAJS
Copy link
Contributor

@shivankacker We can close this issue as we already have a ready to merge PR #56 for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants