Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off set is not passed to the backend properly in the facility specific users page #10727

Closed
2 tasks
nihal467 opened this issue Feb 20, 2025 · 6 comments
Closed
2 tasks
Assignees
Labels
P1 breaking issue or vital feature

Comments

@nihal467
Copy link
Member

nihal467 commented Feb 20, 2025

Describe the bug

When the users API is called from the facility specific users tab, the offset is not properly handled, caused the pagination to not work properly in the users tab

To Reproduce
Steps to reproduce the behavior:

  1. Go to any facility with more than 20 users (Or Link 20 users to a facility)
  2. Click on user tab
  3. See error

Expected behavior

  • total number of users should be shown properly
  • offset should be handled properly and pagination should work as expected

Screenshots

Image

@nihal467 nihal467 changed the title Total users count in the facillity specific users tab is not properly shown Total users count in the facillity specific users tab is not accurate Feb 20, 2025
@tellmeY18 tellmeY18 added this to Care Feb 20, 2025
@tellmeY18 tellmeY18 moved this to Triage in Care Feb 20, 2025
@rajku-dev
Copy link
Contributor

I would like to fix this @nihal467

@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Feb 20, 2025

@nihal467 s , this is fixed in #10659 could you check and LMK

PS: btw, Please add need-testing and needs review label to above metioned PR as well 😅

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 20, 2025
@nihal467 nihal467 changed the title Total users count in the facillity specific users tab is not accurate Off set is not passed to the backend properly in the facility specific users page Feb 20, 2025
@nihal467 nihal467 added P1 breaking issue or vital feature and removed question Further information is requested needs-triage labels Feb 20, 2025
@nihal467
Copy link
Member Author

@AdityaJ2305 this is a facility-specific user tab pagination issues and the PR you made is solving some issues in the organisation page, are you sure you address this specific issue in your PR

@AdityaJ2305
Copy link
Contributor

@AdityaJ2305 this is a facility-specific user tab pagination issues and the PR you made is solving some issues in the organisation page, are you sure you address this specific issue in your PR

No , it is solving for all tabs

@AdityaJ2305
Copy link
Contributor

I have tested it on deploy preview on my PR. It is fixed
here I have reported same
#10651 (comment)

@rithviknishad
Copy link
Member

Fixed in #10729

@github-project-automation github-project-automation bot moved this from Triage to Done in Care Feb 20, 2025
@rithviknishad rithviknishad removed this from Care Feb 20, 2025
@tellmeY18 tellmeY18 added this to Care Feb 20, 2025
@tellmeY18 tellmeY18 moved this to Done in Care Feb 20, 2025
@tellmeY18 tellmeY18 moved this from Done to In Progress in Care Feb 20, 2025
@rithviknishad rithviknishad removed this from Care Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature
Projects
None yet
Development

No branches or pull requests

4 participants