Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointments Tab Username Search Results Are Limited to the Initially Loaded 15 Entries #10721

Closed
nihal467 opened this issue Feb 20, 2025 · 10 comments
Labels
needs-triage question Further information is requested

Comments

@nihal467
Copy link
Member

Describe the bug

When searching for a user in the Appointments tab, the search only filters through the first 15 names loaded initially, instead of considering all available data.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any facility and in the appointments tab
  2. search for a user
  3. See error

Expected behavior

Necessary request should be fired to get search result from all available data in appointments

Screenshots

Image

@tellmeY18 tellmeY18 moved this to Triage in Care Feb 20, 2025
@tellmeY18 tellmeY18 added this to Care Feb 20, 2025
@Rishith25
Copy link
Contributor

@nihal467 I would like to work on this

@Sulochan-khadka
Copy link
Contributor

@nihal467 kindly assign me this issue

@ashwinpraveengo
Copy link
Contributor

@nihal467 I would like to work on this issue:

My approach:

  • The search should fetch results from the complete dataset, not just preloaded records.
  • Modify the search logic to trigger an API request that retrieves and filters results from the backend.

@nihal467 nihal467 added the P1 breaking issue or vital feature label Feb 20, 2025
@tellmeY18 tellmeY18 moved this from Triage to In Progress in Care Feb 20, 2025
@nihal467
Copy link
Member Author

@Rishith25 its a priority issue, do push the fix by EOD

@Rishith25
Copy link
Contributor

Rishith25 commented Feb 20, 2025

Hey @nihal467
You mean username searching for practitioners right?
If yes can i know which facility have more than 15 practitioners and also credentials becz currently in Poojappura PHC we have only 4 practitoners linked
cc: @Jacobjeevan @rithviknishad

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 20, 2025
@nihal467
Copy link
Member Author

@Rishith25 feel free to create a new facility with more than 15 practitioners

@nihal467 nihal467 removed question Further information is requested needs-triage labels Feb 20, 2025
@rithviknishad
Copy link
Member

@Rishith25 you can momentarily set the limit to less than 4 or so; so that resultset gives has results in other pages; this should work as long as the search query is sent to the backend; regardless of the size (15)

@Rishith25
Copy link
Contributor

@nihal467 @rithviknishad

I have added 20 practictioners and all practitioners are visible in dropdown. I think there was no limit set for fetching users and initially all users are loading .

And also we are not passing any search query params in api call

Can you once confirm it or i am missing some thing 👀

Image

Image

@rithviknishad
Copy link
Member

@nihal467 I don't see any issue here, this particular API will give ALL users that has a schedule in the facility in the first call to the API itself and the rest is filtered at client side.

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Feb 21, 2025
@rithviknishad rithviknishad removed this from Care Feb 21, 2025
@tellmeY18 tellmeY18 added this to Care Feb 21, 2025
@rithviknishad rithviknishad removed the P1 breaking issue or vital feature label Feb 21, 2025
@tellmeY18 tellmeY18 moved this to Done in Care Feb 21, 2025
@rithviknishad rithviknishad removed this from Care Feb 21, 2025
@Rishith25
Copy link
Contributor

@nihal467 I don't see any issue here, this particular API will give ALL users that has a schedule in the facility in the first call to the API itself and the rest is filtered at client side.

Yeah that's what I found

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants