Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-purge weird behavior #2107

Open
peregrineshahin opened this issue Jul 6, 2024 · 4 comments
Open

auto-purge weird behavior #2107

peregrineshahin opened this issue Jul 6, 2024 · 4 comments

Comments

@peregrineshahin
Copy link
Contributor

Suppose a run has auto purge on, and the code of the run is bugged and keeps crashing for most/all the games, the question is does it make sense to enter an infinite loop of purging the tasks and resuming/restarting the run?
Solution: don't restart/resume any run automatically after pruging

@dubslow
Copy link
Contributor

dubslow commented Jul 6, 2024

yea but what about when the purge is legit and the run should be resumed.

possibly it may make sense to use your solution, since users can still manually restart a run which was correctly purged back into the llr window...?

@peregrineshahin
Copy link
Contributor Author

yea but what about when the purge is legit and the run should be resumed.

possibly it may make sense to use your solution, since users can still manually restart a run which was correctly purged back into the llr window...?

Yes sure.

@vdbergh
Copy link
Contributor

vdbergh commented Jul 6, 2024

Dunno. If the run does not restart people also complain (not everyone is aware of the modify hack).

EDIT: I don't feel strongly about this. The server code would be simpler if the run does not auto-restart (this would mean that stop_run() is guaranteed to stop a run, which is currently not the case).

@peregrineshahin
Copy link
Contributor Author

Dunno. If the run does not restart people also complain (not everyone is aware of the modify hack).

GitHub uses this trick, the same button can have different options
maybe this is the equivalent in bootstrap https://getbootstrap.com/docs/5.3/components/button-group/#nesting
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants