Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small todos from the next dev cycle #5567

Open
3 of 4 tasks
vondele opened this issue Sep 6, 2024 · 6 comments
Open
3 of 4 tasks

Small todos from the next dev cycle #5567

vondele opened this issue Sep 6, 2024 · 6 comments

Comments

@vondele
Copy link
Member

vondele commented Sep 6, 2024

Describe the issue

  • copy scripts directory in distributed packages
  • see if avxvnni can be integrated in CI and in release packages
  • remove ARCH=... from readme (only advanced usage)
  • document the help and license commands and command line options (--help, --license)

Expected behavior

fix above todos.

Steps to reproduce

N/A

Anything else?

N/A

Operating system

All

Stockfish version

master

@Disservin
Copy link
Member

Also check if this CI step is really required, https://github.com/official-stockfish/Stockfish/blob/master/.github/workflows/upload_binaries.yml#L40. I have a feeling that the runner already has git and zip, and make shouldnt even be needed.

@Disservin
Copy link
Member

Rename the binary stockfish-macos-m1-apple-silicon to just stockfish-macos-apple-silicon since it should support all later processors as well

@vondele
Copy link
Member Author

vondele commented Sep 6, 2024

Rename the binary stockfish-macos-m1-apple-silicon to just stockfish-macos-apple-silicon since it should support all later processors as well

though if we start adding m2, m3 specific optimizations?

@Disservin
Copy link
Member

mh fair enough, I guess it should be clear enough that a m1 optimized version will/should also run on all m series chips

@cw-sf
Copy link

cw-sf commented Sep 9, 2024

README.md states "a file with the .nnue extension, storing the neural network for the NNUE evaluation. Binary distributions will have this file embedded.", however my understanding is that Stockfish currently includes a secondary neural network, thus two files.

Also, as spelling change suggestions: the CPW refers to itself as "Chess Programming Wiki" and the big endian architecture is spelled "PowerPC".

Should a separate PR be created for this? If at all, that is.

@Disservin
Copy link
Member

I've added the help and license to https://github.com/official-stockfish/Stockfish/wiki/UCI-&-Commands#help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants