simple editor edit cause popup error(IOS18 and chrome browser)

[oeyoews]

No description provided.

[oeyoews]

[oeyoews]

ScreenRecording_10-14-2024.08-13-49_1.mp4

[Jermolene]

Hi @oeyoews I'm running iOS 18. Is there a convenient to reproduce the bug?

[oeyoews]

Hi @oeyoews I'm running iOS 18. Is there a convenient to reproduce the bug?您好，我运行的是 iOS 18。有方便的方法重现该错误吗？

I think the video above should be enough, let me add a text version of the reproduction steps later

[Jermolene]

Ah, I see the URL in the video now. I tried it on tiddlywiki.com with iOS 18 on my iPhone, and didn't encounter the same issue.

[oeyoews]

1. open https://tiddlywiki.com/ on mobile(IOS 18 with chrome or firefox)
2. create a new tiddler
3. and try focus textarea

[oeyoews]

Ah, I see the URL in the video now. I tried it on tiddlywiki.com with iOS 18 on my iPhone, and didn't encounter the same issue.啊，我现在看到视频里的网址了。我在 tiddlywiki.com 上用 iPhone 上的 iOS 18 进行了尝试，没有遇到同样的问题。

Looks weird

[Jermolene]

Do you have any extensions running that could be interfering with things?

[oeyoews]

Do you have any extensions running that could be interfering with things?

try use chrome browser on moblie

[oeyoews]

safari is normal

[Jermolene]

Hi @oeyoews I was able to remote debug iOS Chrome and reproduce the problem. It would be easier to work with a custom build that disabled the global error handler, but even without that we can see that the crash is occurring in the user scripts that Chrome adds to every page:

[oeyoews]

chrome and firefox is also not work, but safari, edge and opera is normal

[Jermolene]

Hi @oeyoews here's where things go wrong. The variable "t" is an Event object, but it doesn't have members "clientX" and "clientY". It's hard to see how there's anything very much TW can be doing that's causing the problem here, it really feels like a problem with Chrome's user script

[oeyoews]

It looks like some bugs are caused by zooming in on the page when it is in focus. Since I don't have a computer at hand right now, I found a few previous versions of wikis on tiddlyhot and tested them, as well as the tiddlywiki starter kit. This further confirmed my initial guess that when editing text, if the page is zoomed in, this error pop-up will appear @Jermolene

[oeyoews]

Another test is to send the current web page to the home screen. Repeat the steps to reproduce, and the error disappears. It seems that in this case the web page no longer depends on the Chrome browser.

[oeyoews]

https://github.com/TiddlyWiki/TiddlyWiki5/compare/v5.1.23..v5.2.0

tw version archive By testing different tw versions, I found that there was no such error in versions before v5.2.0. It seems that the relevant code has changed, such as factory.js @Jermolene

[Jermolene]

Hi @oeyoews I'm pretty sure that the problem is that factory.js is creating synthetic "click" events that lack "clientX" and "clientY" properties. I have tried hacking handleKeydownEvent() to make it construct a proper MouseEvent, but it doesn't appear to help:

if($tw.keyboardManager.checkKeyDescriptors(event,keyInfoArray)) {
	var clickEvent = new MouseEvent("click", {
		bubbles: true,
		cancelable: true,
		view: window,
		clientX: 0,
		clientY: 0
	});
	console.log("Dispatching synthetic event",clickEvent)
	el.dispatchEvent(clickEvent);
	event.preventDefault();
	event.stopPropagation();
	return true;
}

I suspect that the problem actually occurs when an event is cloned in cloneEvent().

[oeyoews]

for cloneEvent method , clientX, clientY is include