Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenise verovio JS dependency #5

Open
musicog opened this issue Apr 16, 2019 · 1 comment
Open

Homogenise verovio JS dependency #5

musicog opened this issue Apr 16, 2019 · 1 comment

Comments

@musicog
Copy link
Contributor

musicog commented Apr 16, 2019

We should use the Verovio supplied by the npm verovio-dev package

@alastair
Copy link
Contributor

I had a quick look at doing this, except if you load it using an import statement, it might go through your build system (it made my node run out of memory and crash). Especially when using create-react-app this doesn't give us the ability to use webpack configuration to exclude it. Perhaps there's a different way that might give us the same benefit...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants