Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log forward port followup to chatter #903

Open
xmo-odoo opened this issue Jun 28, 2024 · 1 comment
Open

Log forward port followup to chatter #903

xmo-odoo opened this issue Jun 28, 2024 · 1 comment
Labels

Comments

@xmo-odoo
Copy link
Collaborator

Currently the forward-port decisions are only logged to, well, the log. Which is very opaque and hard to access (even for me).

It might be a good idea to log it to the source PRs or the chatter (possibly adding a batch chatter for that? would allow tracking batch shit too). One probable limitation in that case is that "wrong state" keeps running possibly forever, so would have to be modified / handled specially in order not to make this a pain in the ass...

Alternatively there could be a special signal to handle this and avoid even trying to schedule followups for PRs or batches which can't have changed (so probably gate _validate to first check the pr / batch state).

@xmo-odoo xmo-odoo moved this to accepted in Mergebot Jun 28, 2024
@xmo-odoo
Copy link
Collaborator Author

xmo-odoo commented Dec 3, 2024

After thinking more about this, I think it would make sense for forwardport batches to be tracked and have their state computed through dependencies through the PR, rather than check the properties we want on every cron run. The cron should only be there to perform the work when the batch is in the right state.

It would also allow surfacing batches stuck in an inconsistent state more easily, though I think currently this just leads to the batch being dropped for the most part? Either way, this ought allow for an easier time posting the final decision / result to the source of the batch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: accepted
Development

No branches or pull requests

1 participant