Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search #28

Closed
stacyk opened this issue Sep 10, 2016 · 4 comments
Closed

Add Search #28

stacyk opened this issue Sep 10, 2016 · 4 comments

Comments

@stacyk
Copy link
Member

stacyk commented Sep 10, 2016

Perhaps we should add a search for easier ways to find things.

(This is for the entire styleguide, while #52 helps filtering a single page)

@mirisuzanne mirisuzanne modified the milestone: Herman 1.0 May 19, 2017
@mirisuzanne mirisuzanne reopened this May 19, 2017
@wlonk wlonk modified the milestones: Herman 1.0, Herman 1.x Stretch Goals May 22, 2017
@jgerigmeyer jgerigmeyer assigned mirisuzanne, stacyk and SondraE and unassigned wlonk Nov 20, 2017
@jgerigmeyer
Copy link
Member

@mirisuzanne @stacyk @SondraE It'd be helpful to have a basic design mockup for this feature. Where does the search bar live -- on every page? on a dedicated Search page? Where are results displayed?

@stacyk
Copy link
Member Author

stacyk commented Nov 20, 2017

@jgerigmeyer I was thinking it could be either top right or in nav on left. then it is on every page, but results would be shown where the main content normally is on its own dedicated results page.
Mockup placement of search isn't to scale. :)

search-mock

@mirisuzanne
Copy link
Member

Nav bar location will work at all page sizes. Let's start there? Then we can add to the top-bar on large screens if we want.

@jgerigmeyer
Copy link
Member

Fixed by #203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants