Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read info about known color issues #143

Closed
SondraE opened this issue Nov 22, 2023 · 3 comments · Fixed by #146
Closed

Read info about known color issues #143

SondraE opened this issue Nov 22, 2023 · 3 comments · Fixed by #146
Labels
a11y Improvements for a more accessible experience bug Something isn't working sprint: current

Comments

@SondraE
Copy link
Contributor

SondraE commented Nov 22, 2023

Scope

  • add an unobtrusive information section that is expanded on larger screens and collapsed on smaller screen to help interested people understand the known color issues
  • this section can go into as much detail as needed and even include color swatches to help people understand the foreground color issue related to alpha

Mockups

Here are the warning-related Figma file links.
Note: I don't know why Figma is suddenly displaying green lines around various bits of the mockups, and I haven't found the way to turn that view off yet.

Background Alpha Alert + Color Issue Info
https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=112-2&mode=design&t=lOyosYvXrteuMN5Z-0

Foreground Alpha Alert
https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=12%3A348&mode=design&t=4CwzTDrU2fakSiQ4-1

Mobile Alerts + Color Issue Info
https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=83%3A10&mode=design&t=4CwzTDrU2fakSiQ4-1

Mobile Alerts + Color Issue Info 2
https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=83%3A11&mode=design&t=4CwzTDrU2fakSiQ4-1

@SondraE SondraE added sprint: current bug Something isn't working a11y Improvements for a more accessible experience labels Nov 22, 2023
@stacyk stacyk assigned dvdherron and unassigned stacyk Dec 5, 2023
@dvdherron dvdherron assigned stacyk and unassigned jamesnw and dvdherron Dec 18, 2023
@stacyk stacyk assigned dvdherron and unassigned stacyk Dec 18, 2023
@dvdherron dvdherron assigned SondraE and stacyk and unassigned dvdherron Dec 19, 2023
@SondraE
Copy link
Contributor Author

SondraE commented Dec 19, 2023

LGTM!

@SondraE SondraE removed their assignment Dec 19, 2023
@stacyk stacyk assigned jamesnw and jgerigmeyer and unassigned stacyk and jamesnw Dec 21, 2023
@jgerigmeyer jgerigmeyer removed their assignment Dec 23, 2023
@jgerigmeyer
Copy link
Member

#146 is close to merge, but it looks like this issue also includes notes about alpha in contrast ratios. Is that going to be addressed in #91 instead?

@jamesnw
Copy link
Contributor

jamesnw commented Jan 2, 2024

@jgerigmeyer Yes- we'll add those as part of #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Improvements for a more accessible experience bug Something isn't working sprint: current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants