From a382094c461048ff476f499b587bdc3c060ae2e3 Mon Sep 17 00:00:00 2001 From: cortadocodes Date: Fri, 16 Aug 2024 11:44:29 +0100 Subject: [PATCH] FIX: Fix conflation of `None` and `False` in `Analysis.finalise` --- octue/resources/analysis.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/octue/resources/analysis.py b/octue/resources/analysis.py index bb2ff3fba..cd2f45f1b 100644 --- a/octue/resources/analysis.py +++ b/octue/resources/analysis.py @@ -164,7 +164,8 @@ def finalise(self, upload_output_datasets_to=None, use_signed_urls=None): if self.output_location and not upload_output_datasets_to: upload_output_datasets_to = storage.path.join(self.output_location, coolname.generate_slug()) - use_signed_urls = use_signed_urls or self.use_signed_urls_for_output_datasets + if use_signed_urls is None: + use_signed_urls = self.use_signed_urls_for_output_datasets # If there isn't both an output manifest and upload location, nothing is uploaded. if not (upload_output_datasets_to and hasattr(self, "output_manifest")):