Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ [ FEAT REQ ] Auto clean on copy code #143

Open
31337-4554551n opened this issue Aug 1, 2024 · 6 comments
Open

✏️ [ FEAT REQ ] Auto clean on copy code #143

31337-4554551n opened this issue Aug 1, 2024 · 6 comments
Labels
enhancement New feature or request 🧠 need thinkies

Comments

@31337-4554551n
Copy link

Is your feature request related to a problem? If so, please describe the problem.
When an SMS with a 2fa code comes in, I am able to copy it directly from the notification. Which is wonderful. But I then still have to go back to mark it as read/archive it.

Describe the feature you'd like
The option to auto mark read sms when using the copy code function. Even better would be an additional option to mark read and send to archive when using the copy code option.

Additional context
N/A

@31337-4554551n 31337-4554551n added the enhancement New feature or request label Aug 1, 2024
@John-Gee
Copy link

Not just on copy, but also after a certain amount of time. 2fa codes only work for so long, even if the text wasn't copied/read there's no value in keeping it after days.

@octoshrimpy
Copy link
Owner

This would require quik messing with the clipboard, and we can't guarantee that you haven't copied something else in the meantime. to remove it after a certain amount of time would mean quik would have to read your clipboard to see if it's the same as what it copied, and then overwrite. that means storing the code for that duration, and being able to read whatever you copied between "copy code" and timer end. That sounds like an invasion of user privacy.

As far as copy > read / archive / delete, let's talk about it more. There's a solution there somewhere.

@octoshrimpy octoshrimpy changed the title Auto clean on copy code✏️ [ FEAT REQ ] ✏️ [ FEAT REQ ] Auto clean on copy code Nov 2, 2024
@31337-4554551n
Copy link
Author

Yea, the clipboard thing I don't think is relevant, that was someone elses comment unrelated to the issue. If you've got a stale entry that won't work any way, who cares.

But yes. An option to archive/delete/mark read/remove notification, on click of the copy button would be really handy. I use it several times a day, the annoyance of having to go back stacks up lol.

I'd also really like to thank you for having the option to copy out the code from the notification in the first place. That is absolutely fantastic and a huge selling point for me.
Thank you.

@John-Gee
Copy link

John-Gee commented Nov 2, 2024

. to remove it after a certain amount of time would mean quik would have to read your clipboard to see if it's the same as what it copied, and then overwrite. that means storing the code for that duration, and being able to read whatever you copied between "copy code" and timer end. That sounds like an invasion of user privacy.

No, 2FA are time based, it doesn't matter if the code was copied or not in the clipboard, after say an hour there is no benefit of keeping the SMS anymore irrelevantly of if it was read or not as the code wouldn't work anyway.

If you think of it that way, you don't need delete on copy anymore, since you have a garbage collector in place. Now for people with lots of SMSs it might still be much nicer to delete right away rather than waiting for the timer.

@31337-4554551n
Copy link
Author

. to remove it after a certain amount of time would mean quik would have to read your clipboard to see if it's the same as what it copied, and then overwrite. that means storing the code for that duration, and being able to read whatever you copied between "copy code" and timer end. That sounds like an invasion of user privacy.

No 2FA are time based, it doesn't matter if the code was copied or not in the clipboard, after say an hour there is no benefit of keeping the SMS anymore irrelevantly of if it was read or not as the code wouldn't work anyway.

Yea, that was sort of my point. There's no security concerns in keeping it in the clipboard, and empty clipboard VS a random number in it when the next thing you'll do with your clipboard is put something else in there is neither here nor there. Dev work for a feature that almost literally does nothing seems both a waste, and completely unrelated to this feature request.
Let's stop talking about it here, and leave this conversation to the feature in the OP that the Dev has expressed an interest in.

@John-Gee
Copy link

John-Gee commented Nov 2, 2024

Yea, that was sort of my point. There's no security concerns in keeping it in the clipboard, and empty clipboard VS a random number in it when the next thing you'll do with your clipboard is put something else in there is neither here nor there. Dev work for a feature that almost literally does nothing seems both a waste, and completely unrelated to this feature request. Let's stop talking about it here, and leave this conversation to the feature in the OP that the Dev has expressed an interest in.

I'm not talking about the clipboard at all. I'm just saying at receive time + T delete the SMS automatically. Not sure where the confusion arises. It does what you asked for and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🧠 need thinkies
Projects
Status: Backlog
Development

No branches or pull requests

3 participants