Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share authorization with octokit.net #280

Open
MatisseHack opened this issue Nov 4, 2022 · 2 comments
Open

Share authorization with octokit.net #280

MatisseHack opened this issue Nov 4, 2022 · 2 comments
Labels
Type: Feature New feature or request

Comments

@MatisseHack
Copy link

I need to use both octokit.net and octokit.graphql.net in the same project and I wish I could more easily share authorization tokens between both SDKs. I've written an ICredentialStore to cache and refresh authorization tokens, but this interface is slightly different between octokit.net and octokit.graphql.net, which complicates the implementation unnecessarily.

It's a pretty minor issue, but I wish these two packages worked together more seamlessly. One possible solution would be to extract authorization related code into a separate package that both projects could depend on. Such a change might also help address #128

@kfcampbell kfcampbell added Priority: Normal Type: Feature New feature or request labels Nov 8, 2022
@nickfloyd
Copy link
Contributor

Hey @MatisseHack,

This is one of the future design changes we hope to make as we begin leaning into generative SDKs - we'd like to abstract things such as models, auth, caching, throttling, and the like, which could easily be referenced in, as you suggest. We've got a little ways to go to get things moving in that direction, but until then, please join the discussion here and here - we'd love to have your voice and thoughts woven into the future of what this might all look like in the future.

@MatisseHack
Copy link
Author

Great to hear it's already on the radar! I'll chime in there if I can think of anything to add. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

3 participants