Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install foot-terminfo package #1399

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

install foot-terminfo package #1399

wants to merge 4 commits into from

Conversation

oski-bear
Copy link

@oski-bear oski-bear commented Sep 13, 2023

@jaysa68 uses this terminal emulator

@ocfjenkins
Copy link

ocfjenkins bot commented Sep 13, 2023

Errored hosts (64)

Changed hosts (0)

Unaffected hosts (0)

WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/ocfbot/338c729ec68c0c83944316a878b2617e

Jenkins

Copy link
Member

@nikhiljha nikhiljha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this errored because codename is a string not a number. For an example of how to do this, see...

# TODO: remove this once we no longer support stretch (and move to above
# packages block)
if $::os[distro][codename] != 'stretch' {
package {
'kitty-terminfo':;
}
}

@nikhiljha nikhiljha self-assigned this Sep 18, 2023
@nikhiljha nikhiljha changed the title "maybe you should PR getting foot-terminfo installed on all ocf machi… install foot-terminfo package Sep 18, 2023
@ocfjenkins
Copy link

ocfjenkins bot commented Sep 18, 2023

Errored hosts (66)

Changed hosts (0)

Unaffected hosts (0)

WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/ocfbot/7994df5f42d334c9acdf5d0b6942716c

Jenkins

Copy link
Member

@nikhiljha nikhiljha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this still fails because of an extra space on line 137...

[2023-09-18T20:09:49.871Z] Trim Trailing Whitespace........................................................................Failed
[2023-09-18T20:09:49.871Z] - hook id: trailing-whitespace
[2023-09-18T20:09:49.871Z] - exit code: 1
[2023-09-18T20:09:49.871Z] - files were modified by this hook
[2023-09-18T20:09:49.871Z] 
[2023-09-18T20:09:49.871Z] Fixing modules/ocf/manifests/packages.pp
[2023-09-18T20:09:49.871Z] 

To avoid issues like this in the future you should install the pre-commit hooks: https://github.com/ocf/puppet#linting-and-validating-the-puppet-config

@nikhiljha
Copy link
Member

Also, foot-terminfo is only available on bullseye or higher, so you can't put this in the same block.

See https://packages.debian.org/bullseye/foot-terminfo

@ocfjenkins
Copy link

ocfjenkins bot commented Sep 18, 2023

Errored hosts (0)

Changed hosts (65)

Unaffected hosts (1)


Changed hosts
diff for acid.ocf.berkeley.edu, anthrax.ocf.berkeley.edu, arsenic.ocf.berkeley.edu, asteroid.ocf.berkeley.edu, autocrat.ocf.berkeley.edu, avalanche.ocf.berkeley.edu, bedbugs.ocf.berkeley.edu, bermudatriangle.ocf.berkeley.edu, bigbang.ocf.berkeley.edu, biohazard.ocf.berkeley.edu, blackout.ocf.berkeley.edu, blight.ocf.berkeley.edu, blizzard.ocf.berkeley.edu, chaos.ocf.berkeley.edu, corruption.ocf.berkeley.edu, coup.ocf.berkeley.edu, cyanide.ocf.berkeley.edu, cyclone.ocf.berkeley.edu, dataloss.ocf.berkeley.edu, deadlock.ocf.berkeley.edu, death.ocf.berkeley.edu, dementors.ocf.berkeley.edu, democracy.ocf.berkeley.edu, destruction.ocf.berkeley.edu, dev-death.ocf.berkeley.edu, drought.ocf.berkeley.edu, fallingrocks.ocf.berkeley.edu, famine.ocf.berkeley.edu, firestorm.ocf.berkeley.edu, firewhirl.ocf.berkeley.edu, flood.ocf.berkeley.edu, fraud.ocf.berkeley.edu, frostbite.ocf.berkeley.edu, gridlock.ocf.berkeley.edu, hailstorm.ocf.berkeley.edu, hal.ocf.berkeley.edu, headcrash.ocf.berkeley.edu, heatwave.ocf.berkeley.edu, hurricane.ocf.berkeley.edu, implosion.ocf.berkeley.edu, invasion.ocf.berkeley.edu, lethe.ocf.berkeley.edu, lightning.ocf.berkeley.edu, madcow.ocf.berkeley.edu, maelstrom.ocf.berkeley.edu, meteorstorm.ocf.berkeley.edu, outbreak.ocf.berkeley.edu, pestilence.ocf.berkeley.edu, plague.ocf.berkeley.edu, quarantine.ocf.berkeley.edu, reaper.ocf.berkeley.edu, riptide.ocf.berkeley.edu, scurvy.ocf.berkeley.edu, segfault.ocf.berkeley.edu, sinkhole.ocf.berkeley.edu, supernova.ocf.berkeley.edu, surge.ocf.berkeley.edu, thunder.ocf.berkeley.edu, tornado.ocf.berkeley.edu, tsunami.ocf.berkeley.edu, venom.ocf.berkeley.edu, volcano.ocf.berkeley.edu, whiteout.ocf.berkeley.edu, wildfire.ocf.berkeley.edu, windshear.ocf.berkeley.edu
*******************************************
+ Package[foot-terminfo] =>
   parameters =>
     "allow_virtual": false
*******************************************
Unaffected hosts
vampires.ocf.berkeley.edu

Jenkins

@ethanwu10
Copy link
Member

#1351 relevant (I should really get that merged...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants