Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: allow pkg for release builds #11378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkg: allow pkg for release builds #11378

wants to merge 1 commit into from

Conversation

gridbugs
Copy link
Collaborator

Fixes #11375

@rgrinberg do you remember why "--ignore-lock-dir" was added to the arguments passed by "--release"? Is it now safe to remove?

@gridbugs
pkg: allow pkg for release builds
676cccf 
Signed-off-by: Stephen Sherratt <[email protected]>
@Leonidas-from-XIV
Copy link
Collaborator

Shouldn't --ignore-lock-dir be added to the options of -p instead? Since we want to avoid OPAM triggering dune pkg.

@rgrinberg
Copy link
Member

-p triggers --release. So yes, this is the reason. Opam release builds should ignore lock directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Awaiting requested review from Leonidas-from-XIV

@rgrinberg rgrinberg Awaiting requested review from rgrinberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dune does not download dependencies in release profile
3 participants
@gridbugs @Leonidas-from-XIV @rgrinberg