Possible FD leakage in OS X

[camlspotter]

I got the following error when I run omake -P and recompile many things in OS X:

omake: "omake_shell_spawn_posix/open" failed: Too many open files

[camlspotter]

Tried omake.0.10.2 + the patch of #86 . #86 is not likely the cause of this issue since it does not change any file I/O.

[camlspotter]

I see lots of fds for omake....divert left open in the Activity Monitor.

[gerdstolpmann]

Tried to reproduce this, but no success. All descriptors were closed (I was watching with dtruss while triggering recompilations).

Does increasing the max number of descriptors help? On mac the limit is only 256 by default (ulimit -n).

[camlspotter]

omake.0.9.8.6-0.rc1 compiled with the same OCaml 4.04.0 in the same OS X never leaks FDs for omake.*.divert files. I guess this was introduced in 0.10.x.

[gerdstolpmann]

This is possible. I'll double-check the code.

[camlspotter]

Ping. If there is no immediate plan to fix, I have to roll all my omake uses back to 0.9.8.6-0.rc1...

[gerdstolpmann]

I cannot fix something without being able to reproduce it.