Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider timeouts #28

Closed
polytypic opened this issue Feb 16, 2023 · 1 comment · Fixed by #86
Closed

Consider timeouts #28

polytypic opened this issue Feb 16, 2023 · 1 comment · Fixed by #86

Comments

@polytypic
Copy link
Collaborator

polytypic commented Feb 16, 2023

During a recent talk a question on the detection of problems such as starvation came up. One potential solution/helper for those could be just to add support for timeouts. It should already be possible to implement the equivalent of commit, which is basically a loop calling attempt, outside of the library and include a timeout mechanism, but perhaps it would make sense e.g. to add an optional argument to commit to specify a timeout. As the timeout would then likely only need to be examined after attempt failure, it could be (with a bit of care) implemented so that it adds almost no overhead (i.e. examine the optional timeout only after the first failure).

@polytypic
Copy link
Collaborator Author

Noting here that the technique of using attempt to write a version of commit with a timeout is no longer available as attempt was removed. However, with suitable system facilities it is still possible to have commits with timeouts without having to modify commit by implementing the equivalent of registerDelay.

@polytypic polytypic linked a pull request Jun 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant