-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip network tests when network is unavailable #275
Comments
Hello, @talex5 @patricoferris -- Is this issue still open? |
Yes. This would be a good first step: realworldocaml/mdx#393 |
Thank you @talex5 -- I'll have to wait for @patricoferris to assign me the issue. |
Assigned :)) |
Hello @talex5 and @patricoferris -- A couple of clarifications are needed. I have been trying understand where to begin from. Since it talks of network tests and extending the MDX, I want to be sure if it's the network.md file i am to work with. Also, I would appreciate directions to any link where i can read more on MDX and to know how best to impement the skip network logic. Thanks |
To get started, you can try running the tests under Docker, using the Dockerfile in the repository. e.g.
I just tried this, and it seems that Docker does provide IPv6 now (at least on the loopback interface). However, it now blocks uring:
So probably the tests will need changing to Note: this is marked "good first issue" as it doesn't require much knowledge of Eio and the changes needed here are simple. However, adding the skip feature to MDX might be more difficult! |
Hello @patricoferris -- I am making my Outreachy final application and I am asked to create a project timeline. Following the Project details, I came up with a timeline. I want to share it with you so if there's any correction before I submit, or something you want me to insert or remove. Here's the link: https://docs.google.com/document/d/108a5nU0J9Z2tFIUR09lwPmwww4796qpFVx3nZNSKilc/edit?usp=drivesdk |
The network tests can't be run in some cases:
This is probably best done by extending MDX. We could perhaps have an
exception Mdx_skip_block
to indicate that the current block's output should be ignored, or askip-if=TEST
label at the top of the block.From #274.
The text was updated successfully, but these errors were encountered: