-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] obus 2.0 #23
base: master
Are you sure you want to change the base?
[WIP] obus 2.0 #23
Conversation
This seems like a fairly extensive set of changes to files but not much of a change to the code. Can you summarize what you've done? I'm not sure I'm in a very good position to review it meaningfully. |
@pmetzger It's not done yet. There are much more changes to the files indeed because the code is pretty good. As I've mentioned in #17 , the main goal of The second main goal is to split So here is what is/shall be done in this PR:
I'm also thinking of dropping bindings for this release since they didn't age well in many places and need a thorough update due to changes in related APIs. Anyways they would be in separate packages so I could publish them later. What are you thinking about all of this? |
It all seems quite reasonable so far. Again, though, I'm not a domain expert (and know nothing about who is using this code and what they expect from the old interfaces.) |
AFAIK @talex5 uses it, so I'll ping him. |
This is an effort on making obus more simple and modular, as well as small and easy to maintain. See #17.