Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js_of_ocaml fails to run on multicore #18

Open
ctk21 opened this issue May 2, 2019 · 3 comments · May be fixed by #310
Open

js_of_ocaml fails to run on multicore #18

ctk21 opened this issue May 2, 2019 · 3 comments · May be fixed by #310
Labels
good first issue Good for newcomers

Comments

@ctk21
Copy link
Member

ctk21 commented May 2, 2019

See issue #17 on how to get frama-c building on multicore.

js_of_ocaml was failing with Error: Js_of_ocaml_compiler__Instr.Bad_instruction(983041)

might be additional bytecode instructions added in multicore and not supported by js_of_ocaml?

@shakthimaan shakthimaan moved this to Backlog in Benchmarking Feb 15, 2022
@shakthimaan shakthimaan added the good first issue Good for newcomers label Mar 28, 2022
@moazzammoriani
Copy link
Contributor

May I work on this?

@Sudha247
Copy link
Contributor

Hi @moazzammoriani! Thanks for volunteering to work on this issue. I've described the next steps below, do ask if something is unclear.

I hope you've been able to setup OCaml on your machine. Let us know if there are any issues with it, we can sort that out.

The first step I'd suggest is to start a run of sandmark on 5.0.0+trunk. You can do it with this script from within sandmark directory: https://github.com/ocaml-bench/sandmark/blob/main/run_all_serial.sh

sh run_all_serial.sh

should do the trick.

After the run is over, you'll be able to see the results in the _results directory.

Next, js_of_ocaml is currently disabled for the benchmark run. To enable it again, you'll need to remove it from the list here: https://github.com/ocaml-bench/sandmark/blob/main/ocaml-versions/5.0.0%2Btrunk.json#L20. Now, do the run again. You should see the js_of_ocaml dependency failing and run not completing. It's because the version in the dependencies does not work with our compiler. Post the failure message here if you see it. Let me know once you are done with the above two items, I'll add more details on how to fix the error. You can also create a draft PR after removing js_of_ocaml from the 5.0.0+trunk file and we can go from there.

@moazzammoriani moazzammoriani linked a pull request Mar 28, 2022 that will close this issue
@moazzammoriani
Copy link
Contributor

Hi, I have done as you asked and drafted the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants