Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming suggestions for *run_config.json files #302

Open
kayceesrk opened this issue Mar 3, 2022 · 7 comments
Open

Renaming suggestions for *run_config.json files #302

kayceesrk opened this issue Mar 3, 2022 · 7 comments
Labels
good first issue Good for newcomers

Comments

@kayceesrk
Copy link
Contributor

Currently the names of the json files are not illustrative and one has to look at the description in https://github.com/ocaml-bench/sandmark#config-files to know what they mean. Here is a renaming suggestion:

  • run_config.json -> sequential.json
  • multicore_parallel_run_config.json -> parallel_turing.json
  • multicore_parallel_navajo_run_config.json -> parallel_navajo.json
  • micro_multicore.json -> micro.json
@Sudha247 Sudha247 added the good first issue Good for newcomers label Mar 28, 2022
@moazzammoriani
Copy link
Contributor

@Sudha247 can I rename these as per the suggestion?

@Sudha247
Copy link
Contributor

Hi @moazzammoriani, thanks for the interest. I'd suggest taking this up after finishing #310, if no one has claimed it by then. I must also admit #310 is a bit more challenging than this one, but I hope it's also more rewarding. :)

@codeamic
Copy link

Hi Sudha, can i work on this?

@Sudha247
Copy link
Contributor

Hi @codeamic, sure you may work on it.

@codeamic
Copy link

Thank you @Sudha247, i am on it

@fomalhauting
Copy link

@Sudha247 If this issue hasn't been resolved yet, I would love to work on it as a part of my outreach application.

@moazzammoriani
Copy link
Contributor

moazzammoriani commented Apr 19, 2022

Thank you for you interest @itsIapetus but I believe this issue has been taken up by @codeamic and they already generated a PR as well.

@kayceesrk kayceesrk moved this to Todo in hackocaml Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants