has_mask may fail on mmdet instance segmentation model

[Alias-z]

According to https://github.com/obss/sahi/blob/main/sahi/models/mmdet.py#L243-L244, sahi only returns segmentation masks if self.has_mask==True. However, https://github.com/obss/sahi/blob/main/sahi/models/mmdet.py#L193 indicates the has_mask = self.model.model.with_mask, which may not work sometimes.

For example, this mask2former config in mmdet is meant for instance segmentation, but return False if accessing its .with_mask attribute, leading to empty segmentation results.

A solution could be

def check_with_mask_in_list(lst):
    """Check if 'with_mask' key exists in any dictionaries within the list and is set to True."""
    for item in lst:
        # Check if the item is a dictionary and 'with_mask' is a key set to True
        if isinstance(item, dict) and item.get('with_mask', False) is True:
            return True
    return False
check_with_mask_in_list(model['train_dataloader']['dataset']['dataset']['pipeline'])

which means we check the train_dataloader if annotation was loaded with masks, likely to be a universal solution for mmdet cases.

I could do a PR if needed :)

Add a proof:

  'bboxes': array([[ 667,  910,  718,  943],
         [ 176,  821,  237,  855],
         [ 987,  489, 1020,  546],
         [ 966,  721, 1011,  772],
         [ 311,  634,  373,  664],
         [1040,  215, 1100,  250],
         [ 551,   61,  615,  100],
         [ 735,  593,  803,  629],
         [ 322,   25,  348,   89],
         [  71,  429,  119,  483],
         [ 368,  356,  399,  414],
         [ 789,  105,  839,  138],
         [ 612,  344,  648,  400],
         [  39,   21,  107,   71],
         [1248,  161, 1274,  219]]),
  'masks': array([[[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]],
  
         [[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]],
  
         [[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]],
  
         ...,
  
         [[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]],
  
         [[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]],
  
         [[False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          ...,
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False],
          [False, False, False, ..., False, False, False]]])},

[fcakyon]

A pr would be great @Alias-z !

[fcakyon]

This should be available in v0.11.18 🚀 #1062