From ffecee76b3a4feafb6803504cd80f6975aa9caf8 Mon Sep 17 00:00:00 2001 From: Sarah Gliner <105934250+sgliner-ledger@users.noreply.github.com> Date: Tue, 27 Feb 2024 17:24:07 +0100 Subject: [PATCH 1/4] [auto] Update screenshot --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 98b720f..f2fb620 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,5 +4,5 @@ - [ ] Target branch is `develop` - [ ] Application version has been bumped - From a7b353bde96d054b2b144c950a06b395e9a676d7 Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 2 May 2024 10:13:06 +0200 Subject: [PATCH 2/4] Fix binariy artifact path in functional tests --- .github/workflows/functional_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/functional_tests.yml b/.github/workflows/functional_tests.yml index 4e76af8..e77929e 100644 --- a/.github/workflows/functional_tests.yml +++ b/.github/workflows/functional_tests.yml @@ -93,8 +93,8 @@ jobs: - name: Run test run: | - BIN_DIR_NAME="$(echo ${{ matrix.device }} | sed 's/nanosp/nanos2/')" - speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/build/${BIN_DIR_NAME}/bin/app.elf --display headless & + BIN_DIR_NAME="$(echo ${{ matrix.device }} | sed 's/nanosp/nanosplus/')" + speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/${BIN_DIR_NAME}/release/sui.elf --display headless & sleep 5 cd ts-tests echo "Doing yarn install" From 52dfe9b98729ce6a62f5741a7fba6cfb2b47d57c Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 2 May 2024 13:50:48 +0200 Subject: [PATCH 3/4] Fix elf name (no .elf extension) --- .github/workflows/functional_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/functional_tests.yml b/.github/workflows/functional_tests.yml index e77929e..26b6633 100644 --- a/.github/workflows/functional_tests.yml +++ b/.github/workflows/functional_tests.yml @@ -94,7 +94,7 @@ jobs: - name: Run test run: | BIN_DIR_NAME="$(echo ${{ matrix.device }} | sed 's/nanosp/nanosplus/')" - speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/${BIN_DIR_NAME}/release/sui.elf --display headless & + speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/${BIN_DIR_NAME}/release/sui --display headless & sleep 5 cd ts-tests echo "Doing yarn install" From 82a2c7361d9069503dd828b218cbdb247ddbd8c8 Mon Sep 17 00:00:00 2001 From: GroM Date: Thu, 2 May 2024 14:00:47 +0200 Subject: [PATCH 4/4] Fix build binary artifact path --- .github/workflows/functional_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/functional_tests.yml b/.github/workflows/functional_tests.yml index 26b6633..2bd88d5 100644 --- a/.github/workflows/functional_tests.yml +++ b/.github/workflows/functional_tests.yml @@ -94,7 +94,7 @@ jobs: - name: Run test run: | BIN_DIR_NAME="$(echo ${{ matrix.device }} | sed 's/nanosp/nanosplus/')" - speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/${BIN_DIR_NAME}/release/sui --display headless & + speculos --api-port 5005 ${{ needs.call_get_app_metadata.outputs.build_directory }}/build/${BIN_DIR_NAME}/release/sui --display headless & sleep 5 cd ts-tests echo "Doing yarn install"