Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_bitinformation: want to skip a variable if dim missing or return None for it's information content along missing dim #108

Open
aaronspring opened this issue May 24, 2022 · 0 comments

Comments

@aaronspring
Copy link
Collaborator

LGTM! I think it addresses only the first part of @rsignell-usgs comment of

I'd like to specify the "y" dimensions in a list, e.g. dim = ['eta_rho', 'eta_u', 'eta_v'] and then use whichever one is found for a specific variable.

though.
If a variable in a dataset with dims 'eta_rho', 'eta_u', 'eta_v' only depends on 'eta_v', the code might currently fail when e.g. dim='eta_rho' is provided. We could discuss if we just want to skip that variable in this case or return None for it's information content along dim=eta_rho.
Nevertheless, this PR is self-containing, so not objections to merge this directly.

Originally posted by @observingClouds in #106 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant