From fece905bb901fb02dfaa53669cbcb0d282d2145b Mon Sep 17 00:00:00 2001 From: Joe Sirianni Date: Mon, 8 Jul 2024 10:11:45 -0400 Subject: [PATCH 1/2] Increase default timeout from 20s to 60s --- internal/client/client.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/internal/client/client.go b/internal/client/client.go index 2487f25..70149e6 100644 --- a/internal/client/client.go +++ b/internal/client/client.go @@ -16,7 +16,11 @@ import ( "go.uber.org/zap" ) -const KeyHeader = "X-Bindplane-Api-Key" +const ( + KeyHeader = "X-Bindplane-Api-Key" + + DefaultTimeout = time.Second * 60 +) type BindPlane struct { logger *zap.Logger @@ -28,7 +32,10 @@ type BindPlane struct { func NewBindPlane(config *config.Config, logger *zap.Logger) (*BindPlane, error) { restryClient := resty.New() restryClient.SetDisableWarn(true) - restryClient.SetTimeout(time.Second * 20) + + // Resty defaults to 60 seconds, but we want to be clear + // that we are setting a timeout here. + restryClient.SetTimeout(DefaultTimeout) restryClient.SetBasicAuth(config.Auth.Username, config.Auth.Password) From 92a41bd7e49b3b1defa5a50e581a14938297d130 Mon Sep 17 00:00:00 2001 From: Joe Sirianni Date: Mon, 8 Jul 2024 10:13:08 -0400 Subject: [PATCH 2/2] remove old comment --- internal/client/client.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/client/client.go b/internal/client/client.go index 70149e6..804e529 100644 --- a/internal/client/client.go +++ b/internal/client/client.go @@ -32,9 +32,6 @@ type BindPlane struct { func NewBindPlane(config *config.Config, logger *zap.Logger) (*BindPlane, error) { restryClient := resty.New() restryClient.SetDisableWarn(true) - - // Resty defaults to 60 seconds, but we want to be clear - // that we are setting a timeout here. restryClient.SetTimeout(DefaultTimeout) restryClient.SetBasicAuth(config.Auth.Username, config.Auth.Password)