Merge branch 'develop' into feature-2645/feedback-request-add-ability…

…-to-request-feedback-from-external-source # Conflicts: # server/src/main/java/com/objectcomputing/checkins/services/feedback_answer/FeedbackAnswerServices.java # server/src/main/java/com/objectcomputing/checkins/services/feedback_answer/FeedbackAnswerServicesImpl.java # server/src/main/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServices.java # server/src/main/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServicesImpl.java
objectcomputing · Nov 13, 2024 · 165b301 · 165b301
2 parents 38a9104 + c7dd3a0
commit 165b301
Show file tree

Hide file tree

Showing 16 changed files with 198 additions and 217 deletions.
diff --git a/server/build.gradle b/server/build.gradle
@@ -7,7 +7,7 @@ plugins {
     id "jacoco"
 }
 
-version "0.8.7"
+version "0.8.8"
 group "com.objectcomputing.checkins"
 
 repositories {

diff --git a/...in/java/com/objectcomputing/checkins/services/feedback_answer/FeedbackAnswerServices.java b/...in/java/com/objectcomputing/checkins/services/feedback_answer/FeedbackAnswerServices.java
@@ -1,5 +1,6 @@
 package com.objectcomputing.checkins.services.feedback_answer;
 
+import com.objectcomputing.checkins.services.feedback_request.FeedbackRequest;
 import io.micronaut.core.annotation.Nullable;
 
 import java.util.List;
@@ -14,4 +15,6 @@ public interface FeedbackAnswerServices {
     FeedbackAnswer getById(UUID id);
 
     List<FeedbackAnswer> findByValues(@Nullable UUID questionId, @Nullable UUID requestId, @Nullable UUID externalRecipientId);
-}
+
+    boolean getIsPermitted(FeedbackRequest feedbackRequest);
+ }
diff --git a/.../checkins/services/feedback_answer/question_and_answer/QuestionAndAnswerServicesImpl.java b/.../checkins/services/feedback_answer/question_and_answer/QuestionAndAnswerServicesImpl.java
@@ -42,7 +42,7 @@ public QuestionAndAnswerServicesImpl(FeedbackAnswerServices feedbackAnswerServic
     @Override
     public List<Tuple> getAllQuestionsAndAnswers(UUID requestId) {
         FeedbackRequest feedbackRequest = feedbackRequestServices.getById(requestId);
-        if (!getIsPermitted(feedbackRequest)) {
+        if (!feedbackAnswerServices.getIsPermitted(feedbackRequest)) {
             throw new PermissionException(NOT_AUTHORIZED_MSG);
         }
         List<TemplateQuestion> templateQuestions = templateQuestionServices.findByFields(feedbackRequest.getTemplateId());
@@ -77,7 +77,7 @@ public Tuple getQuestionAndAnswer(@Nullable UUID requestId, @Nullable UUID quest
         TemplateQuestion question = new TemplateQuestion();
         FeedbackRequest feedbackRequest = feedbackRequestServices.getById(requestId);
 
-        if (!getIsPermitted(feedbackRequest)) {
+        if (!feedbackAnswerServices.getIsPermitted(feedbackRequest)) {
             throw new PermissionException(NOT_AUTHORIZED_MSG);
         }
 
@@ -101,18 +101,4 @@ public Tuple getQuestionAndAnswer(@Nullable UUID requestId, @Nullable UUID quest
         }
         return new Tuple(question, returnedAnswer);
     }
-
-    public boolean getIsPermitted(FeedbackRequest feedbackRequest) {
-        final boolean isAdmin = currentUserServices.isAdmin();
-        final UUID requestCreatorId = feedbackRequest.getCreatorId();
-        UUID requesteeId = feedbackRequest.getRequesteeId();
-        MemberProfile requestee = memberProfileServices.getById(requesteeId);
-        final UUID currentUserId = currentUserServices.getCurrentUser().getId();
-        final UUID recipientId = feedbackRequest.getRecipientId();
-        boolean isRequesteesSupervisor = requesteeId != null ? memberProfileServices.getSupervisorsForId(requesteeId).stream().anyMatch(profile -> currentUserId.equals(profile.getId())) : false;
-        final UUID requesteePDL = requestee.getPdlId();
-
-        return isAdmin || currentUserId.equals(requesteePDL) || isRequesteesSupervisor || requestCreatorId.equals(currentUserId) || recipientId.equals(currentUserId);
-    }
-
 }
diff --git a/.../java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServices.java b/.../java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServices.java
@@ -14,4 +14,6 @@ public interface FeedbackRequestServices {
     FeedbackRequest getById(UUID id);
 
     List<FeedbackRequest> findByValues(UUID creatorId, UUID requesteeId, UUID recipientId, LocalDate oldestDate, UUID reviewPeriodId, UUID templateId, UUID externalRecipientId, List<UUID> requesteeIds);
+
+    boolean selfRevieweeIsCurrentUserReviewee(FeedbackRequest request, UUID currentUserId);
 }
diff --git a/...a/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServicesImpl.java b/...a/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServicesImpl.java
@@ -418,6 +418,23 @@ private boolean isSupervisor(UUID requesteeId, UUID currentUserId) {
                 && memberProfileServices.getSupervisorsForId(requesteeId).stream().anyMatch(profile -> currentUserId.equals(profile.getId()));
     }
 
+    public boolean selfRevieweeIsCurrentUserReviewee(FeedbackRequest request,
+                                                     UUID currentUserId) {
+        // If we are looking at a self-review request, see if there is a review
+        // request in the same review period that is assigned to the current
+        // user and the requestee is the same as the self-review request.  If
+        // so, this user is allowed to see the self-review request.
+        if (request.getRecipientId().equals(request.getRequesteeId())) {
+            List<FeedbackRequest> other = feedbackReqRepository.findByValues(
+                null, request.getRecipientId().toString(),
+                currentUserId.toString(), null,
+                Util.nullSafeUUIDToString(request.getReviewPeriodId()),
+                null);
+            return (other.size() == 1);
+        }
+        return false;
+    }
+
     private boolean createIsPermitted(UUID requesteeId) {
         final boolean isAdmin = currentUserServices.isAdmin();
         final UUID currentUserId = currentUserServices.getCurrentUser().getId();

diff --git a/.../main/java/com/objectcomputing/checkins/services/memberprofile/MemberProfileServices.java b/.../main/java/com/objectcomputing/checkins/services/memberprofile/MemberProfileServices.java
@@ -9,6 +9,8 @@
 public interface MemberProfileServices {
     MemberProfile getById(UUID id);
 
+    MemberProfile findByWorkEmail(@NotNull String workEmail);
+
     Set<MemberProfile> findByValues(String firstName, String lastName, String title,
                                     UUID pdlId, String workEmail, UUID supervisorId, Boolean terminated);
 

diff --git a/...n/java/com/objectcomputing/checkins/services/memberprofile/MemberProfileServicesImpl.java b/...n/java/com/objectcomputing/checkins/services/memberprofile/MemberProfileServicesImpl.java
@@ -13,6 +13,7 @@
 import com.objectcomputing.checkins.services.role.RoleServices;
 import com.objectcomputing.checkins.services.team.member.TeamMemberServices;
 import io.micronaut.cache.annotation.CacheConfig;
+import io.micronaut.cache.annotation.CacheInvalidate;
 import io.micronaut.cache.annotation.Cacheable;
 import io.micronaut.core.annotation.Nullable;
 import jakarta.inject.Named;
@@ -55,6 +56,7 @@ public MemberProfileServicesImpl(MemberProfileRepository memberProfileRepository
     }
 
     @Override
+    @Cacheable
     public MemberProfile getById(@NotNull UUID id) {
         Optional<MemberProfile> optional = memberProfileRepository.findById(id);
         if (optional.isEmpty()) {
@@ -67,6 +69,14 @@ public MemberProfile getById(@NotNull UUID id) {
         return memberProfile;
     }
 
+    @Cacheable
+    @Override
+    public MemberProfile findByWorkEmail(@NotNull String workEmail) {
+        return memberProfileRepository.findByWorkEmail(workEmail).orElseThrow(() ->
+                new NotFoundException("Member not found")
+        );
+    }
+
     @Override
     public Set<MemberProfile> findByValues(@Nullable String firstName,
                                            @Nullable String lastName,
@@ -86,6 +96,7 @@ public Set<MemberProfile> findByValues(@Nullable String firstName,
     }
 
     @Override
+    @CacheInvalidate(cacheNames = {"member-cache"})
     public MemberProfile saveProfile(MemberProfile memberProfile) {
         MemberProfile emailProfile = memberProfileRepository.findByWorkEmail(memberProfile.getWorkEmail()).orElse(null);
 
@@ -152,6 +163,7 @@ public void emailAssignment(MemberProfile member, boolean isPDL) {
     }
 
     @Override
+    @CacheInvalidate(cacheNames = {"member-cache"})
     public boolean deleteProfile(@NotNull UUID id) {
         if (!currentUserServices.isAdmin()) {
             throw new PermissionException("Requires admin privileges");
@@ -183,6 +195,7 @@ public boolean deleteProfile(@NotNull UUID id) {
     }
 
     @Override
+    @Cacheable(parameters = {"firstName", "lastName"})
     public MemberProfile findByName(@NotNull String firstName, @NotNull String lastName) {
         List<MemberProfile> searchResult = memberProfileRepository.search(firstName, null, lastName,
                 null, null, null, null, null, null);
@@ -222,6 +235,7 @@ public List<MemberProfile> getSubordinatesForId(UUID id) {
     }
 
     @Override
+    @CacheInvalidate(cacheNames = {"member-cache"})
     public MemberProfile updateProfile(MemberProfile memberProfile) {
         return memberProfileRepository.update(memberProfile);
     }

diff --git a/server/src/main/java/com/objectcomputing/checkins/services/reports/CSVProcessor.java b/server/src/main/java/com/objectcomputing/checkins/services/reports/CSVProcessor.java
@@ -1,8 +1,8 @@
 package com.objectcomputing.checkins.services.reports;
 
-import com.objectcomputing.checkins.services.memberprofile.MemberProfileRepository;
 import com.objectcomputing.checkins.exceptions.BadArgException;
 
+import com.objectcomputing.checkins.services.memberprofile.MemberProfileServices;
 import org.apache.commons.csv.CSVFormat;
 import org.apache.commons.csv.CSVParser;
 
@@ -18,7 +18,7 @@
 
 abstract class CSVProcessor {
 
-  public void load(MemberProfileRepository memberProfileRepository,
+  public void load(MemberProfileServices memberProfileServices,
                    ByteBuffer dataSource) throws IOException,
                                                  BadArgException {
     ByteArrayInputStream stream = new ByteArrayInputStream(dataSource.array());
@@ -30,10 +30,10 @@ public void load(MemberProfileRepository memberProfileRepository,
                     .setNullString("")
                     .build()
                     .parse(input);
-    loadImpl(memberProfileRepository, csvParser);
+    loadImpl(memberProfileServices, csvParser);
   }
 
-  protected abstract void loadImpl(MemberProfileRepository memberProfileRepository, CSVParser csvParser) throws BadArgException;
+  protected abstract void loadImpl(MemberProfileServices memberProfileServices, CSVParser csvParser) throws BadArgException;
 
   protected LocalDate parseDate(String date) {
     List<String> formatStrings = List.of("yyyy", "M/d/yyyy");

diff --git a/server/src/main/java/com/objectcomputing/checkins/services/reports/CompensationHistory.java b/server/src/main/java/com/objectcomputing/checkins/services/reports/CompensationHistory.java
@@ -1,9 +1,10 @@
 package com.objectcomputing.checkins.services.reports;
 
+import com.objectcomputing.checkins.exceptions.NotFoundException;
 import com.objectcomputing.checkins.services.memberprofile.MemberProfile;
-import com.objectcomputing.checkins.services.memberprofile.MemberProfileRepository;
 import com.objectcomputing.checkins.exceptions.BadArgException;
 
+import com.objectcomputing.checkins.services.memberprofile.MemberProfileServices;
 import io.micronaut.core.annotation.Introspected;
 import org.apache.commons.csv.CSVParser;
 import org.apache.commons.csv.CSVRecord;
@@ -12,10 +13,7 @@
 import org.slf4j.LoggerFactory;
 
 import java.time.LocalDate;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.UUID;
-import java.util.Optional;
+import java.util.*;
 
 public class CompensationHistory extends CSVProcessor {
 
@@ -32,41 +30,39 @@ public record Compensation(
     private final List<Compensation> history = new ArrayList<>();
 
     @Override
-    protected void loadImpl(MemberProfileRepository memberProfileRepository,
+    protected void loadImpl(MemberProfileServices memberProfileServices,
                             CSVParser csvParser) throws BadArgException {
-      history.clear();
-      for (CSVRecord csvRecord : csvParser) {
-        try {
-          String emailAddress = csvRecord.get("emailAddress");
-          Optional<MemberProfile> memberProfile =
-              memberProfileRepository.findByWorkEmail(emailAddress);
-          if (memberProfile.isPresent()) {
-              String startDate = csvRecord.get("startDate");
-              LocalDate date = parseDate(startDate);
-            if (date == null) {
-              LOG.error("Unable to parse date: {}", startDate);
-            } else {
-              String value = csvRecord.get("compensation");
-              Compensation comp = new Compensation(
-                      memberProfile.get().getId(),
-                      date,
-                      value == null ? null : value.replaceAll("[^\\d\\.,]", ""),
-                      csvRecord.get("totalComp")
-              );
-              history.add(comp);
+        history.clear();
+        for (CSVRecord csvRecord : csvParser) {
+            String emailAddress = null;
+            try {
+                emailAddress = csvRecord.get("emailAddress");
+                MemberProfile memberProfile = memberProfileServices.findByWorkEmail(emailAddress);
+                String startDate = csvRecord.get("startDate");
+                LocalDate date = parseDate(startDate);
+                if (date == null) {
+                    LOG.error("Unable to parse date: {}", startDate);
+                } else {
+                    String value = csvRecord.get("compensation");
+                    Compensation comp = new Compensation(
+                            memberProfile.getId(),
+                            date,
+                            value == null ? null : value.replaceAll("[^\\d\\.,]", ""),
+                            csvRecord.get("totalComp")
+                    );
+                    history.add(comp);
+                }
+            } catch (NotFoundException nfe) {
+                LOG.error("Unable to find a profile for {}", emailAddress);
+            } catch (IllegalArgumentException ex) {
+                throw new BadArgException("Unable to parse the compensation history");
             }
-          } else {
-            LOG.error("Unable to find a profile for {}", emailAddress);
-          }
-        } catch(IllegalArgumentException ex) {
-          throw new BadArgException("Unable to parse the compensation history");
         }
-      }
     }
 
     public List<Compensation> getHistory(UUID memberId) {
-      return history.stream()
-              .filter(entry -> entry.memberId().equals(memberId))
-              .toList();
+        return history.stream()
+                .filter(entry -> entry.memberId().equals(memberId))
+                .toList();
     }
 }