Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings in lwIP build #528

Closed
christian-herber opened this issue Jul 14, 2020 · 2 comments · Fixed by #955
Closed

Fix compiler warnings in lwIP build #528

christian-herber opened this issue Jul 14, 2020 · 2 comments · Fixed by #955

Comments

@christian-herber
Copy link

The lwip build is currently suffering from a lot of compiler warnings (mainly) due to unused parameters:

Just taking net.c as an example:

/libcoap/src/net.c:711:71: warning: unused parameter 'node' [-Wunused-parameter]
/libcoap/src/net.c:1108:27: warning: unused parameter 'ctx' [-Wunused-parameter]
/libcoap/src/net.c:1108:44: warning: unused parameter 'now' [-Wunused-parameter]
/libcoap/src/net.c:2577:12: warning: variable 'us' set but not used [-Wunused-but-set-variable]
/libcoap/src/net.c:2803:29: warning: format '%d' expects argument of type 'int', but argument 2 has type 'coap_tick_t' {aka 'long unsigned int'} [-Wformat=]

These issues should be fixed to clean the build output. For unused parameters, make it explicit they are not used e.g. by
(void) node;
and so on.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Jul 23, 2022

libcoap LwIP support has been re-written in PR #884, and so this should no longer be an issue.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Oct 21, 2022

See #955 for a fix fir the compiler warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants