Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate lwip configuration files from code #527

Closed
christian-herber opened this issue Jul 13, 2020 · 2 comments
Closed

Separate lwip configuration files from code #527

christian-herber opened this issue Jul 13, 2020 · 2 comments

Comments

@christian-herber
Copy link

For integration purposes and flexibility, it is important to separate application code from configuration files (e.g. to include configuration files from a location outside of this git)

currently, the following config files are in the git:

  • include/coap2/lwippools.h (this is quite odd. other applications might also need to define memory pools, so this shouldn't be in the main include directory)
  • examples/lwip/lwipopts.h (same directory contains the header for server examples)

Propsed Solution:

Move both files into a separate folder examples/lwip/config
While we are at it, also move coap_config.h (respectively the link to it)

This will create a single folder containing the configuration files.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Jul 23, 2022

libcoap LwIP support has been re-written in PR #884, and so this should no longer be an issue. Configuration files are now in the examples/lwip.config/ directory.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Sep 22, 2022

Closed as fixed in #926 which is now in the develop branch. There is now a config directory.

@mrdeep1 mrdeep1 closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants