Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/socket.h and netinet/in.h should not be included for any embedded target #526

Closed
christian-herber opened this issue Jul 13, 2020 · 2 comments

Comments

@christian-herber
Copy link

Currently, inclusion of these headers is guarded for CONTIKI in libcoap.h

#include <netinet/in.h>
#include <sys/socket.h>
#endif /* CONTIKI */</code>

However, other systems, e.g. FreeRTOS + lwIP would run into the same limitations. These headers are not needed in the lwIP port.

Proposal would be to have a general macro which skips inclusion of these, which can be automatically defined in case CONTIKI is defined.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Jul 23, 2022

libcoap LwIP support has been re-written in PR #884, and so this should no longer be an issue. The required header files are now in build type specific files.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Sep 22, 2022

Closed as fixed in #926 which is now in the develop branch.

@mrdeep1 mrdeep1 closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants