From cda8f3b66f131f04238819d0efe19f161820df11 Mon Sep 17 00:00:00 2001
From: Manuel Namici <manuel.namici@gmail.com>
Date: Tue, 19 Apr 2022 09:39:42 -0700
Subject: [PATCH] core: owl: allow all facets for custom data properties

Before this commit, attempting to build an OWL expression of the form:

DatatypeRestriction(my:dataType <facet> [<facet])

would result in an exception being thrown due to the fact that for
custom datatypes there is no known constraining facet applicable.
While it is arguable whether to allow restricting custom datatypes
with contraining facets since there is no known facet space defined
for the datatype, the thrown exception definetely represents a bug
due to the Facet enum not being able to deal with custom datatypes.

This commit fixes this behaviour, while taking a relaxed approach
on what facets can be applied to custom datatypes, essentially
allowing the use of all possible constraining facets since even if
this has no clear semantic meaning (hence no reasoning will be possible),
it is still syntactically correct.
If at a later time we decide that this kind of expression should be
forbidden by the syntactic check, it would be enough to simply return
an empty set of facets for custom datatypes.

See: #177
---
 eddy/core/owl.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eddy/core/owl.py b/eddy/core/owl.py
index 063e963f..5cb4841e 100644
--- a/eddy/core/owl.py
+++ b/eddy/core/owl.py
@@ -2177,7 +2177,7 @@ def forDatatype(cls, value):
         :type value: IRI
         :rtype: list
         """
-        allvalues = [x for x in cls]
+        allvalues = [x.value for x in cls]
         numbers = [OWL2Facet.maxExclusive.value, OWL2Facet.maxInclusive.value, OWL2Facet.minExclusive.value, OWL2Facet.minInclusive.value]
         strings = [OWL2Facet.langRange.value, OWL2Facet.length.value, OWL2Facet.maxLength.value, OWL2Facet.minLength.value, OWL2Facet.pattern.value]
         binary = [OWL2Facet.length.value, OWL2Facet.maxLength.value, OWL2Facet.minLength.value]
@@ -2218,4 +2218,4 @@ def forDatatype(cls, value):
             OWL2Datatype.unsignedLong.value: numbers,
             OWL2Datatype.unsignedShort.value: numbers,
             OWL2Datatype.XMLLiteral.value: []
-        }[value]
+        }.get(value, allvalues)