Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFLATE in ZLIB #94

Closed
bc-pi opened this issue Jan 15, 2024 · 2 comments · Fixed by #100
Closed

DEFLATE in ZLIB #94

bc-pi opened this issue Jan 15, 2024 · 2 comments · Fixed by #100
Milestone

Comments

@bc-pi
Copy link

bc-pi commented Jan 15, 2024

maybe adjust the language around DEFLATE and ZLIB per this thread

Originally posted by @bc-pi in #80 (comment)

@c2bo
Copy link
Member

c2bo commented Jan 16, 2024

Copied over, to have everything in the issue here:
This is the current text:

The complete byte array is compressed using the "DEFLATE" {{RFC1951}} compression method and stored using the "ZLIB" {{RFC1950}} data format. Implementations are RECOMMENDED to use the highest compression level available.

This is the proposal:

The complete byte array is compressed using DEFLATE {{RFC1951}} inside the ZLIB {{RFC1950}} data format. Implementations are RECOMMENDED to use the highest compression level available.

I agree that the current text is a bit weird and I wasn't really sure how to formulate it better when writing it.

@bc-pi
Copy link
Author

bc-pi commented Jan 16, 2024

More context copied over via Screenshot:

Screenshot 2024-01-16 at 7 08 02 AM

@paulbastian paulbastian added this to the -02 milestone Feb 6, 2024
@paulbastian paulbastian linked a pull request Feb 7, 2024 that will close this issue
@c2bo c2bo closed this as completed in #100 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants