Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask: Add Oasis logo when adding Sapphire network #423

Open
matevz opened this issue Oct 1, 2024 · 9 comments
Open

MetaMask: Add Oasis logo when adding Sapphire network #423

matevz opened this issue Oct 1, 2024 · 9 comments
Assignees
Labels
blocked Pull requests that are blocked by another issue integrations

Comments

@matevz
Copy link
Member

matevz commented Oct 1, 2024

Even though you must add the Oasis network manually, it seems MetaMask can still show a network-specific logo in the network list (e.g. Gnosis was added manually):

image

Find a way to show the Oasis Sapphire (+Testnet) and Emerald (+Testnet) icons when adding networks to Metamask. This article may be useful https://support.metamask.io/managing-my-tokens/custom-tokens/how-to-add-a-token-logo/

I have no idea where chainlist.org got Emerald icon from:
image

The "official" ethereum list of chains is here though:
https://github.com/ethereum-lists/chains/tree/master/_data/chains

@lukaw3d
Copy link
Member

lukaw3d commented Oct 28, 2024

I have no idea where chainlist.org got Emerald icon from

https://github.com/DefiLlama/chainlist/blob/79955609484c8eac1e4c12f5f7b962992add0ce8/pages/chain/%5Bchain%5D.js#L72

    return chain?.chainSlug ? `https://icons.llamao.fi/icons/chains/rsz_${chain.chainSlug}.jpg` : "/unknown-logo.png";

https://github.com/DefiLlama/chainlist/blob/79955609484c8eac1e4c12f5f7b962992add0ce8/utils/fetch.js#L45

    const chainSlug = chainIds[chain.chainId];

https://github.com/DefiLlama/chainlist/blob/6fe47d2cf7aa02bec528a4d303d6959021a72917/constants/chainIds.js#L64

  42262: "oasis",

@aefhm
Copy link
Contributor

aefhm commented Oct 29, 2024

I think they like controlling their own repo. MetaMask/metamask-extension#28168

@aefhm
Copy link
Contributor

aefhm commented Oct 31, 2024

@matevz @lukaw3d It is just the one logo right?

Screenshot 2024-10-31 at 4 41 57 PM

@aefhm
Copy link
Contributor

aefhm commented Nov 1, 2024

See also DefiLlama/chainlist#1361

@aefhm
Copy link
Contributor

aefhm commented Nov 1, 2024

I have no idea where chainlist.org got Emerald icon from: image

They have this repo.

@aefhm aefhm self-assigned this Nov 1, 2024
@aefhm
Copy link
Contributor

aefhm commented Nov 2, 2024

Also see DefiLlama/icons#1983.

@aefhm
Copy link
Contributor

aefhm commented Nov 5, 2024

I need to fix the mobile build and complete this MetaMask/metamask-mobile#12141

@aefhm aefhm added the blocked Pull requests that are blocked by another issue label Nov 6, 2024
@aefhm
Copy link
Contributor

aefhm commented Nov 20, 2024

TODO

@aefhm
Copy link
Contributor

aefhm commented Dec 5, 2024

Moving mobile fix to separate issue #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull requests that are blocked by another issue integrations
Projects
None yet
Development

No branches or pull requests

3 participants