clients: Support Brave wallet default #411
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #385 maybe.
Problem
Wagmi is concerned with bad implementations of
EIP-1193
and wants to check that theremoveListener
function exists. However, the Brave wallet overridesethereum
properties and does not like the way we currently useProxy
objects, giving a typeerror upon aget
call.Our current implementation is a classic Proxy pattern in order to preserve
this
.simplified to:
sapphire-paratime/clients/js/src/provider.ts
Line 211 in 42c1a69
One solution is to not forward context in order to maintain the function signature for Brave browsers as noted in this PR.