Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapphire-py: Bump web3 to 7.x #355

Open
matevz opened this issue Aug 23, 2024 · 1 comment
Open

sapphire-py: Bump web3 to 7.x #355

matevz opened this issue Aug 23, 2024 · 1 comment
Assignees
Labels

Comments

@matevz
Copy link
Member

matevz commented Aug 23, 2024

sapphire-py is currently compatible with 6.x version of Web3. Bump it to 7.x and fix any compatibility issues.

@CedarMist
Copy link
Member

CedarMist commented Aug 26, 2024

re web3.py 7.x: not many people are using it yet

There are breaking changes from 6.x to 7.x and it's only just been released.

There's no sapphire-py package on PyPi yet, and nobody is using the package apart from Ocean protocol. See: https://github.com/oceanprotocol/sapphire.py which is used by https://github.com/oceanprotocol/pdr-backend - pdr-backend pins "web3==6.20.2"

If anything, I'd say a compatibility wrapper for Ocean, using the Web3.py version they use, with a function wrapper that means they don't have to build & ship a binary blob for encrypted Sapphire transactions is higher priority.


Re: breaking changes

======================================================================
ERROR: sapphirepy.tests.test_e2e (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: sapphirepy.tests.test_e2e
Traceback (most recent call last):
  File "/usr/lib/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/runner/work/sapphire-paratime/sapphire-paratime/clients/py/sapphirepy/tests/test_e2e.py", line 9, in <module>
    from web3.middleware import construct_sign_and_send_raw_middleware
ImportError: cannot import name 'construct_sign_and_send_raw_middleware' from 'web3.middleware' (/home/runner/.local/lib/python3.10/site-packages/web3/middleware/__init__.py)

@CedarMist CedarMist added this to the clients-py-0.4.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants