Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sapphire-contracts: Flaky Gas padding test #337

Open
matevz opened this issue Jul 19, 2024 · 1 comment
Open

sapphire-contracts: Flaky Gas padding test #337

matevz opened this issue Jul 19, 2024 · 1 comment
Labels
contracts Pull requests that update sapphire-contracts

Comments

@matevz
Copy link
Member

matevz commented Jul 19, 2024 •
edited
Loading

Gas padding in the CI tests is sometimes flaky for +/- 1. For example here.

SUMMARY
  1) Gas Padding
       Gas Padding works as Expected:
      AssertionError: expected 132741 to equal 132742. The numerical values of the given "bigint" and "bigint" inputs were compared, and they differed.
      + expected - actual
      -132741
      +132742
      
      at Context.<anonymous> (test/gas.ts:26:40)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
@matevz matevz added the contracts Pull requests that update sapphire-contracts label Jul 19, 2024
@matevz
Copy link
Member Author

matevz commented Jul 19, 2024 •
edited
Loading

Workaround for now https://github.com/oasisprotocol/sapphire-paratime/pull/332/files#diff-27993bdc7c99c800edccb88d59a02e792f012d5764aae55a8efaa2d6b0b46e2bR26-R29

@matevz matevz mentioned this issue Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Pull requests that update sapphire-contracts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matevz