Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add archive web3 gw support #281

Merged
merged 2 commits into from
Jun 3, 2022
Merged

feat: add archive web3 gw support #281

merged 2 commits into from
Jun 3, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented May 27, 2022

No description provided.

@Yawning Yawning requested review from kostko and ptrus as code owners May 27, 2022 11:53
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #281 (b66b4b0) into main (1f8f4ff) will decrease coverage by 2.16%.
The diff coverage is 11.93%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   62.01%   59.84%   -2.17%     
==========================================
  Files          34       35       +1     
  Lines        3830     3990     +160     
==========================================
+ Hits         2375     2388      +13     
- Misses       1257     1397     +140     
- Partials      198      205       +7     
Impacted Files Coverage Δ
archive/client.go 0.00% <0.00%> (ø)
conf/config.go 43.47% <ø> (ø)
main.go 8.42% <0.00%> (-0.52%) ⬇️
storage/psql/psql.go 59.66% <12.50%> (-1.81%) ⬇️
indexer/indexer.go 46.72% <35.29%> (-0.92%) ⬇️
rpc/eth/api.go 51.00% <40.62%> (-1.00%) ⬇️
rpc/apis.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8f4ff...b66b4b0. Read the comment docs.

@Yawning
Copy link
Contributor Author

Yawning commented May 31, 2022

This adds an indexer disable (See #84) but not the event related handling, so the option is only useful to allow archival instances to (in theory) share the db with a non-archival instance.

@Yawning Yawning force-pushed the feature/280 branch 2 times, most recently from 8e41828 to 483e944 Compare June 1, 2022 12:57
This is only for archive support at the moment, and configuring a node
with the indexer disabled will also prevent it from writing to the db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants