Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned Release tags for sapphire-dev container #417

Open
CedarMist opened this issue Aug 16, 2023 · 2 comments
Open

Versioned Release tags for sapphire-dev container #417

CedarMist opened this issue Aug 16, 2023 · 2 comments

Comments

@CedarMist
Copy link
Member

SUMMARY

The sapphire-dev container latest tag will pull an image with whatever the most recent commits are.

If I'm targeting sapphire-dev:latest do I expect to get the latest stable version.

Is it worth the hassle to maintain tagged releases of the docker container for each test & stable release. Maybe another branch for latest-test which is equivalent to latest when it becomes stable.

Suggested tags:

  • stable: mirrors what's deployed on mainnet
  • latest: includes testing releases, upcoming testnet releases
  • edge: whatever's in the git repo
@kostko
Copy link
Member

kostko commented Aug 23, 2023

We could in addition tag based on the PARATIME_VERSION field specified in the Dockerfile? So we would get things like sapphire-dev:0.6.1-testnet in addition to the above automatic tags in case someone wants to test a specific runtime version.

@CedarMist
Copy link
Member Author

CedarMist commented Aug 23, 2023

So, to summarise:

file: docker/${{ matrix.docker_image }}/Dockerfile
tags: |
ghcr.io/oasisprotocol/${{ matrix.docker_image }}:latest
ghcr.io/oasisprotocol/${{ matrix.docker_image }}:latest-${{ env.VERSION }}
push: true
labels: |
org.opencontainers.image.source=${{ github.event.repository.html_url }}
org.opencontainers.image.revision=${{ github.sha }}

Extract PARATIME_VERSION from container and add an additional tag. These won't be pruned as they're not prefixed with latest-.

Will see how to get the PARATIME_VERSION param, and add to #420 if it's a quick addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants