Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Docker images #215

Open
2 tasks
matevz opened this issue Mar 10, 2022 · 0 comments
Open
2 tasks

Add tests for Docker images #215

matevz opened this issue Mar 10, 2022 · 0 comments
Labels
docker Docker related issues tests Unit, integration, e2e tests related issues

Comments

@matevz
Copy link
Member

matevz commented Mar 10, 2022 •
edited
Loading

Currently, the emerald-dev and sapphire-dev images are only built on each push to main, so it can actually break without developer noticing it. Also, even if the image is successfully built, the image might not work (e.g. #214).

Add at least two tests before any PR can be merged:

  • check that the docker images would be successfully built
  • check that the docker images actually start and (at least) successfully populate the accounts (just check the stdout for some 0x addresses?)

Typical issues with images include wrong combination of oasis-core/xyz-paratime/web3-gw versions and oasis-node/web3-gw configuration issues.
@matevz matevz added docker Docker related issues tests Unit, integration, e2e tests related issues labels Mar 10, 2022
@ptrus ptrus mentioned this issue Jun 23, 2022
Merged
@matevz matevz changed the title Add tests for emerald-dev image Add tests for Docker images Jan 24, 2023
@matevz matevz mentioned this issue Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker Docker related issues tests Unit, integration, e2e tests related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matevz