Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymanager: Add mock trusted signers for debug mock SGX builds #5852

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 13, 2024

Useful after #5851 to allow configuring the set of mock trusted signers used by net runner.

@kostko kostko added the c:testing Category: testing label Sep 13, 2024
@kostko kostko self-assigned this Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 28736a2
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/66e400e83c3af9000806d19e

@kostko kostko force-pushed the kostko/feature/debug-mock-signers branch from aaab524 to 663713f Compare September 13, 2024 09:00
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove trusted_signers()?

keymanager/src/policy/signers.rs Outdated Show resolved Hide resolved
@kostko
Copy link
Member Author

kostko commented Sep 13, 2024

Can we remove trusted_signers()?

In the simple-keymanager test runtime? That one doesn't always use the debug-mock-sgx feature though, so the question then is whether exposing this unsafe function is ok.

@kostko kostko force-pushed the kostko/feature/debug-mock-signers branch from 663713f to 28736a2 Compare September 13, 2024 09:07
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good then.

@kostko kostko merged commit d6d15d5 into master Sep 13, 2024
3 checks passed
@kostko kostko deleted the kostko/feature/debug-mock-signers branch September 13, 2024 09:32
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (377082b) to head (28736a2).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5852      +/-   ##
==========================================
- Coverage   64.96%   64.93%   -0.03%     
==========================================
  Files         622      622              
  Lines       63492    63492              
==========================================
- Hits        41246    41229      -17     
+ Misses      17399    17379      -20     
- Partials     4847     4884      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants