Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX]: Revisit activity and transactions tables #1620

Open
3 of 9 tasks
donouwens opened this issue Nov 1, 2024 · 2 comments
Open
3 of 9 tasks

[UX]: Revisit activity and transactions tables #1620

donouwens opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
ux/design UX/UI Design Change Report

Comments

@donouwens
Copy link
Collaborator

IMPACT

  • High
  • Medium
  • Low

URGENCY

  • Critical
  • Major
  • Medium
  • Minor

PRODUCT ENVIRONMENT

No response

DESCRIPTION OF ISSUE

Revisit activity and transactions tables

DEVICE / VIEWPORT

  • Desktop
  • Mobile

STEPS TO REPRODUCE

No response

ALTERNATIVES AND SUGGESTIONS

No response

@donouwens donouwens added the ux/design UX/UI Design Change Report label Nov 1, 2024
@donouwens donouwens self-assigned this Nov 1, 2024
@donouwens
Copy link
Collaborator Author

donouwens commented Dec 11, 2024

Created new iteration for activity view (balanced option we agreed upon before): https://www.figma.com/design/8a1DKD0MYYoVzOk8uQiF5L/Activity-%26-Event-Views?node-id=156-2467&t=fdDPBAxYsasHz3LZ-1

Awaiting feedback from Michał

@buberdds
Copy link
Contributor

buberdds commented Dec 17, 2024

Hey, can you add this topic to the Product Sync meeting, please? Product feedback is more needed here than mine.

Anyway, my initial thoughts:

  • I don't remember what requirements are so it's hard to review 🤷‍♂️
  • Where we gonna show activity table? We render txs and events in multiple places/contexts
  • "Balanced view" supposed to be a merge of txs and events? Should it show stuff like "Deregister Entity", "Evidence" (I cannot find any roothash.Evidence in responses even if method exists) or just more user focused content "Deposits/Withdraws" etc ? No idea.
  • Details column is hard to read for me.
  • Details columns content is not aligned uniformly. Again, "Deregister Entity" is the best example.
  • Padding is not correct in table. If you look at table row, in mockups it is 12px (or 16px in reality). If you look what is happening in "Publish Eph Secret" with "Runtime ID": padding is 12px for all columns, but it is 6px for the last one (Runtime Id) . It has to be the same and keep original "12px" everywhere.
  • Is there some max width for details column width? If that's correct, table rows height will differ and it will be even less readable in real world ("Blobs" can be very long). We might end up with table where each row has different height and each detail column looks differently. It might be even more problematic for lists that have auto-refresh enabled (again not sure where Activity will be added).
  • How this gonna work for mobile vertical layout?
  • If we have so many types here why we are missing KM, vault etc? Is this part of the plan? What about runtimes like ROFLs etc?
  • I think we do not show types lables in multiple lines. We are cutting name and adding "...". "Publish Master Secret" label won't ever be rendered like this
  • Can we use more realistic amounts/shares to catch more edge cases to see how it will all look like? Whether values have more decimals or they are rounded it's up to you. Example: Reclaim Escrow - that's not how we format shares.

Complete diff story is what exactly we want to show in details column. Does mockup take into account feedback from core devs?

  • "Amend Commission Schedule" should have epoch in addition to rates
  • should we show human readable names when we show IDs (whether it is executor or runtime id) and render as proper layer link?
  • "Amend Commission Schedule" again, for users a way how rate is presented does not make any sense. What Rate 20000 is ? We know it is fixed-point representation, but users don't.

etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/design UX/UI Design Change Report
Projects
None yet
Development

No branches or pull requests

2 participants