Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update stake requirements #947

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

rube-de
Copy link
Contributor

@rube-de rube-de commented Sep 19, 2024

@rube-de rube-de requested a review from matevz September 19, 2024 21:17
@rube-de rube-de linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit 78028a6
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/66f67b4bcb66620008eccfed
😎 Deploy Preview https://deploy-preview-947--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rube-de rube-de force-pushed the rube/946-fix-staking-requirements-page branch 4 times, most recently from 8a5edf9 to 4b4dc3a Compare September 23, 2024 12:45
@rube-de rube-de self-assigned this Sep 23, 2024
@rube-de rube-de added the documentation Improvements or additions to documentation label Sep 23, 2024
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky. I think the page now contains too much text. I suggest we get rid of the Testnet/Mainnet subsections and put the data into a table form.

For Consensus:

  • let the rows be entity registration, validator node registration, validator set size
  • let the columns be Mainnet and Testnet

For ParaTime:

  • let the rows be Sapphire, Cipher, Emerald
  • let the columns be Mainnet, Testnet

@rube-de rube-de force-pushed the rube/946-fix-staking-requirements-page branch 4 times, most recently from 5049131 to fb90fbd Compare September 26, 2024 10:56
@rube-de rube-de force-pushed the rube/946-fix-staking-requirements-page branch from 92acaab to f26301a Compare September 26, 2024 15:51
@rube-de rube-de requested a review from matevz September 26, 2024 16:06
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Otherwise looks good!

@rube-de rube-de force-pushed the rube/946-fix-staking-requirements-page branch from f26301a to 5f445cb Compare September 27, 2024 09:28
@rube-de rube-de force-pushed the rube/946-fix-staking-requirements-page branch from 5f445cb to 78028a6 Compare September 27, 2024 09:30
@rube-de rube-de merged commit ded70ed into main Sep 27, 2024
6 checks passed
@rube-de rube-de deleted the rube/946-fix-staking-requirements-page branch September 27, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix staking requirements page
2 participants