Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primitives/sr25519: Enable generating secret keys from ed25519 keys #121

Merged
merged 1 commit into from
Sep 4, 2023
Merged

primitives/sr25519: Enable generating secret keys from ed25519 keys #121

merged 1 commit into from
Sep 4, 2023

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Aug 17, 2023

No description provided.

@kostko kostko requested a review from peternose August 17, 2023 09:38
peternose
peternose reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still against using private keys from scheme A in schemes A and B.

primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys.go Show resolved Hide resolved
@kostko
Copy link
Member

kostko commented Aug 17, 2023

I'm still against using private keys from scheme A in schemes A and B.

This would not be the case, the key would only be used in one scheme, not both. But the derivation process is something that is needed for compatibility with a particular hardware device. Also see related implementation in Rust's schnorrkel for reference.

peternose
peternose approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are following the Rust implementation, then I suppose my comments are redundant.

peternose
peternose reviewed Aug 18, 2023
View reviewed changes
primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys_test.go Outdated Show resolved Hide resolved
primitives/sr25519/keys_test.go Outdated Show resolved Hide resolved
@matevz matevz mentioned this pull request Aug 21, 2023
Merged
peternose
peternose approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

primitives/sr25519/keys.go Outdated Show resolved Hide resolved
primitives/sr25519/keys_test.go Outdated Show resolved Hide resolved
@oasisprotocol oasisprotocol deleted a comment from matevz Aug 24, 2023
@jberci jberci merged commit 1f23a7b into master Sep 4, 2023
1 check passed
@jberci jberci deleted the jberci/feature/keyctor branch September 4, 2023 12:53
@burdges burdges mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peternose peternose peternose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberci @kostko @peternose