Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Increase test coverage #55

Open
Yawning opened this issue May 4, 2021 · 0 comments
Open

tests: Increase test coverage #55

Yawning opened this issue May 4, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Yawning
Copy link
Contributor

Yawning commented May 4, 2021

While a lot of the code is well exercised by the test cases, there are a number of gaps that should also be covered if only to prevent regressions when further development occurs. In particular

  • The ristretto code could use more test cases, particularly on functions that are just wrappers around the corresponding Ed25519 routines.
  • A number of "user-friendlyness" routines in the curve package could use more coverage, such as the constructors and MarshalBinary/UnmarshalBinary routines.

As of right now, none of these routines are used, and they are likely correct, but it won't hurt to make sure they stay correct.

@Yawning Yawning added good first issue Good for newcomers help wanted Extra attention is needed labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant