Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When qemu fails, the retry action only partially reruns commands #30

Open
npf opened this issue Mar 8, 2017 · 1 comment
Open

When qemu fails, the retry action only partially reruns commands #30

npf opened this issue Mar 8, 2017 · 1 comment
Labels

Comments

@npf
Copy link
Contributor

npf commented Mar 8, 2017

When qemu fails, the retry action only partially reruns commands

Branch: refactor
Step: bootstrap/start_qemu.yaml

Only

  - exec_local: |
        qemu-system-$${qemu_arch} $ENABLE_KVM \

is re-executed, with neither ENABLE_KVM nor BOOT_TIMEOUT defined.

Indeed, the former local exec

  - exec_local: |
      if [ "$${qemu_enable_kvm}" = "true" ]; then
        ENABLE_KVM="-enable-kvm -cpu host"
        BOOT_TIMEOUT=$${boot_timeout}
      else
        BOOT_TIMEOUT=$(($${boot_timeout}*2))
      fi

is not re-executed and for some reason, the bash_env file is reset as well, so ENABLE_KVM and BOOT_TIMEOUT are not defined.

@npf npf added the bug label Mar 8, 2017
@npf npf changed the title when qemu fails, the retry action only partially rerun commands When qemu fails, the retry action only partially reruns commands Mar 8, 2017
@npf
Copy link
Contributor Author

npf commented Mar 8, 2017

If this is not considered a bug on the kameleon engine side, maybe should we only have 1 exec_local in the recipe's step?

npf added a commit that referenced this issue Apr 14, 2017
Add boot order=d (cdrom)

Merge steps to that variables are set when the step that runs qemu must
be retried.

Refers to issue #30
npf added a commit that referenced this issue Apr 22, 2017
Add boot order=d (cdrom)

Merge steps to that variables are set when the step that runs qemu must
be retried.

Refers to issue #30
npf pushed a commit that referenced this issue Jan 7, 2020
Fix bug 8056 (had to type pass twice for root in console)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant