Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Replace ValueOrDie with status check #1141

Open
jackylee-ch opened this issue Oct 24, 2022 · 0 comments
Open

Replace ValueOrDie with status check #1141

jackylee-ch opened this issue Oct 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jackylee-ch
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently we use ValueOrDie to check the status, such as LazyBatchIterator.AdvanceTo, and it will directly hang up the current process if there is an exception caused bad status. However, in many cases, it is sufficient to just throw an exception rather than hang up the process, such as the FetchFailedException, which means fetch block failed from other executor. And for Spark, the hanging of the executor process is much more serious than throwing exception, because this will lead to a large number of task recalculations, which may lead to more serious problems.

Describe the solution you'd like
Change the ValueOrDie to status check, and if status not ok, an expression is ok to thrown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant