Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user settings - reset option back to default/installation settings is missing #1390

Closed
sgratch opened this issue Mar 24, 2021 · 1 comment · Fixed by #1424
Closed

user settings - reset option back to default/installation settings is missing #1390

sgratch opened this issue Mar 24, 2021 · 1 comment · Fixed by #1424
Assignees

Comments

@sgratch
Copy link
Member

sgratch commented Mar 24, 2021

Original User Settings design is available here ->https://docs.google.com/document/d/1apA6E4zT21JSJgeO2V3Q_LhK9xq4SOwNeD-gIsG5pNY/edit?pli=1#heading=h.mkd1w7uwr9hs

For more details, check #1088 (comment) (issue 12)

@rszwajko
Copy link
Member

Original design

https://marvelapp.com/prototype/94h0g56/screen/59286966

IMHO we can skip the message next to the button ("Default settings applied") and just disable the button if there is nothing to reset (defaults are used).
Adding the label explaining the state might be required when/if the settings hierarchy would get complex but right now it seem not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants