Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malformatted output in Atom #15

Open
xolotl opened this issue May 11, 2018 · 2 comments
Open

malformatted output in Atom #15

xolotl opened this issue May 11, 2018 · 2 comments

Comments

@xolotl
Copy link

xolotl commented May 11, 2018

Maybe I'm not doing something right, but when I use the Atom package with data like this:

<!-- Contributors START
Bianca_Kramer bmkramer https://101innovations.wordpress.com/ answers doc example
Dan_Whaley dwhly https://hypothes.is/users/dwhly answers example
Daniel_Mietchen Daniel-Mietchen https://about.me/daniel.mietchen code doc answers example design
Fitz_Elliott felliott https://osf.io/rzs6x/ code doc answers example
Heidi_Seibold HeidiSeibold http://heidiseibold.github.io/ doc answers example
Nate_Angell xolotl http://xolotl.org code doc answers example blogpost design
Nici_Pheiffer nicipfeiffer https://osf.io/nsx26/ code doc answers example
Tom_Demeranville TomDemeranville http://demeranville.com/ answers
Contributors END -->
<!-- Contributors table START -->
<!-- Contributors table END -->
This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification.

The package generates malformed output like this (eg, missing [s, malformed table, odd icons of blonde woman):

<!-- Contributors table START -->
| <img src="https://avatars.githubusercontent.com/bmkramer?s=100" width="100" alt="Bianca Kramer" /><br /><sub>Bianca Kramer</sub>](https://101innovations.wordpress.com/)<br />💁 [📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=bmkramer) 💡 | <img src="https://avatars.githubusercontent.com/dwhly?s=100" width="100" alt="Dan Whaley" /><br /><sub>Dan Whaley</sub>](https://hypothes.is/users/dwhly)<br />💁 💡 | <img src="https://avatars.githubusercontent.com/Daniel-Mietchen?s=100" width="100" alt="Daniel Mietchen" /><br /><sub>Daniel Mietchen</sub>](https://about.me/daniel.mietchen)<br />[💻](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=Daniel-Mietchen) [📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=Daniel-Mietchen) 💁 💡 🎨 | <img src="https://avatars.githubusercontent.com/felliott?s=100" width="100" alt="Fitz Elliott" /><br /><sub>Fitz Elliott</sub>](https://osf.io/rzs6x/)<br />[💻](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=felliott) [📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=felliott) 💁 💡 | <img src="https://avatars.githubusercontent.com/HeidiSeibold?s=100" width="100" alt="Heidi Seibold" /><br /><sub>Heidi Seibold</sub>](http://heidiseibold.github.io/)<br />[📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=HeidiSeibold) 💁 💡 | <img src="https://avatars.githubusercontent.com/xolotl?s=100" width="100" alt="Nate Angell" /><br /><sub>Nate Angell</sub>](http://xolotl.org)<br />[💻](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=xolotl) [📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=xolotl) 💁 💡 📝 🎨 | <img src="https://avatars.githubusercontent.com/nicipfeiffer?s=100" width="100" alt="Nici Pheiffer" /><br /><sub>Nici Pheiffer</sub>](https://osf.io/nsx26/)<br />[💻](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=nicipfeiffer) [📖](https://github.com/OpenScienceRoadmap/mozilla-sprint-2018/commits?author=nicipfeiffer) 💁 💡 |
| :---: | :---: | :---: | :---: | :---: | :---: | :---: |

| <img src="https://avatars.githubusercontent.com/TomDemeranville?s=100" width="100" alt="Tom Demeranville" /><br /><sub>Tom Demeranville</sub>](http://demeranville.com/)<br />💁 |
| :---: |
<!-- Contributors table END -->

I'm using Atom 1.26.1, allcontributors 1.1.0 on Mac OS 10.13.4.

@mbad0la
Copy link
Collaborator

mbad0la commented May 12, 2018

Hey @xolotl , thank you raising this issue and being so descriptive about it.
Sadly, I've not been able to maintain this project for a while now and am out of touch with any improvements / changes to the Atom API.
Would you like to solve this issue?

@xolotl
Copy link
Author

xolotl commented May 15, 2018

@mbad0la I would try solve it, except that while I strongly support the goal behind all-contributors, I find that keeping contributions current for a project is too time-consuming and error prone. So even if the atom plugin were working, I don't think I'd implement it. I'm hoping that a service like GitHub might make it easier to expose contributions besides code. I'll leave this here as a note to future explorers about what might not be working right. Thanks for you work on it to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants