Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the numpy version to avoid gltf import failure #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pin the numpy version to avoid gltf import failure #53

wants to merge 1 commit into from

Conversation

Amit-Tomar
Copy link

Fix for issue : #52

@juniorxsound
Copy link
Contributor

Thanks @Amit-Tomar - have you tested this with all images? I suspect this may cause issues with older versions of Blender and would be good to verify that prior to merging and deploying new images

@Amit-Tomar
Copy link
Author

@juniorxsound What is the recommended way to test this with all previous versions ? Generate all images and verify by running the commands mentioned in wiki manually ? or some kind of automation is in place ?

Also wondering if instead of fixing the numpy version for all images, will it make more sense to keep the numpy version Bender version specific ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juniorxsound juniorxsound Awaiting requested review from juniorxsound

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amit-Tomar @juniorxsound