Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies causing issues in node 18 #361

Open
afischer opened this issue Mar 29, 2023 · 0 comments
Open

Circular dependencies causing issues in node 18 #361

afischer opened this issue Mar 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@afischer
Copy link
Member

Context (Environment)

There are three circular dependencies in the app that have been present for quite some time.

  • server/cache.js > server/urlParser.js > server/list.js
  • server/cache.js > server/urlParser.js > server/list.js > server/docs.js
  • server/list.js > server/docs.js > server/formatter.js

These have not caused issues in the past, but when using Node 18 in specific scenarios (so far only seen in linux environments), can cause critical errors in the app.

Solution

Remove the circular dependencies.

@afischer afischer added the bug Something isn't working label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant